| Summary: | RemoteCaptureSampleManager, UserMediaSampleCaptureManagerProxy create the RemoteVideoFrame incorrectly | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Kimmo Kinnunen <kkinnunen> | ||||||||||
| Component: | Media | Assignee: | Kimmo Kinnunen <kkinnunen> | ||||||||||
| Status: | RESOLVED FIXED | ||||||||||||
| Severity: | Normal | CC: | eric.carlson, ews-watchlist, glenn, jer.noble, philipj, sergio, webkit-bug-importer, youennf | ||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||
| Version: | WebKit Nightly Build | ||||||||||||
| Hardware: | Unspecified | ||||||||||||
| OS: | Unspecified | ||||||||||||
| Attachments: |
|
||||||||||||
|
Description
Kimmo Kinnunen
2022-02-24 02:59:40 PST
Created attachment 453088 [details]
Patch
Comment on attachment 453088 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=453088&action=review > Source/WebKit/UIProcess/Cocoa/UserMediaCaptureManagerProxy.cpp:207 > + m_connection->send(Messages::RemoteCaptureSampleManager::VideoSampleAvailable(m_id, WTFMove(properties), metadata), 0); No need for WTFMove. > Source/WebKit/UIProcess/Cocoa/UserMediaCaptureManagerProxy.cpp:213 > + m_connection->send(Messages::RemoteCaptureSampleManager::VideoSampleAvailableCV(m_id, WTFMove(*remoteSample), metadata), 0); No need for WTFMove. Created attachment 453203 [details]
Patch for landing
Created attachment 453204 [details]
Patch for landing
Tools/Scripts/svn-apply failed to apply attachment 453204 [details] to trunk.
Please resolve the conflicts and upload a new patch.
Created attachment 453295 [details]
Patch for landing
Committed r290555 (247833@main): <https://commits.webkit.org/247833@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 453295 [details]. |