Bug 237134

Summary: RemoteCaptureSampleManager, UserMediaSampleCaptureManagerProxy create the RemoteVideoFrame incorrectly
Product: WebKit Reporter: Kimmo Kinnunen <kkinnunen>
Component: MediaAssignee: Kimmo Kinnunen <kkinnunen>
Status: RESOLVED FIXED    
Severity: Normal CC: eric.carlson, ews-watchlist, glenn, jer.noble, philipj, sergio, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing
none
Patch for landing
none
Patch for landing none

Kimmo Kinnunen
Reported 2022-02-24 02:59:40 PST
RemoteCaptureSampleManager, UserMediaSampleCaptureManagerProxy create the RemoteVideoFrame in incorrectly
Attachments
Patch (11.84 KB, patch)
2022-02-24 03:12 PST, Kimmo Kinnunen 		no flags
DetailsFormatted DiffDiff
Patch for landing (11.86 KB, patch)
2022-02-25 05:17 PST, Kimmo Kinnunen 		no flags
DetailsFormatted DiffDiff
Patch for landing (11.84 KB, patch)
2022-02-25 05:23 PST, Kimmo Kinnunen 		no flags
DetailsFormatted DiffDiff
Patch for landing (11.71 KB, patch)
2022-02-26 07:06 PST, Kimmo Kinnunen 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Kimmo Kinnunen
Comment 1 2022-02-24 03:12:42 PST
Created attachment 453088 [details] Patch
youenn fablet
Comment 2 2022-02-24 05:36:37 PST
Comment on attachment 453088 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=453088&action=review > Source/WebKit/UIProcess/Cocoa/UserMediaCaptureManagerProxy.cpp:207 > + m_connection->send(Messages::RemoteCaptureSampleManager::VideoSampleAvailable(m_id, WTFMove(properties), metadata), 0); No need for WTFMove. > Source/WebKit/UIProcess/Cocoa/UserMediaCaptureManagerProxy.cpp:213 > + m_connection->send(Messages::RemoteCaptureSampleManager::VideoSampleAvailableCV(m_id, WTFMove(*remoteSample), metadata), 0); No need for WTFMove.
Kimmo Kinnunen
Comment 3 2022-02-25 05:17:33 PST
Created attachment 453203 [details] Patch for landing
Kimmo Kinnunen
Comment 4 2022-02-25 05:23:47 PST
Created attachment 453204 [details] Patch for landing
EWS
Comment 5 2022-02-26 00:47:48 PST
Tools/Scripts/svn-apply failed to apply attachment 453204 [details] to trunk. Please resolve the conflicts and upload a new patch.
Kimmo Kinnunen
Comment 6 2022-02-26 07:06:32 PST
Created attachment 453295 [details] Patch for landing
EWS
Comment 7 2022-02-26 23:29:03 PST
Committed r290555 (247833@main): <https://commits.webkit.org/247833@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 453295 [details].
Radar WebKit Bug Importer
Comment 8 2022-02-26 23:30:21 PST
<rdar://problem/89522455>
Note You need to log in before you can comment on or make changes to this bug.