Bug 237116 – REGRESSION(r290347-r290348) [ iOS ] http/tests/events/device-orientation-motion-non-secure-context.html is a constant text failure

• Component: New Bugs
• Status: RESOLVED FIXED

[Dawn Morningstar]

http/tests/events/device-orientation-motion-non-secure-context.html
Is a constant failure on iOS.

HISTORY:
https://results.webkit.org/?suite=layout-tests&test=http%2Ftests%2Fevents%2Fdevice-orientation-motion-non-secure-context.html

DIFF:
--- /Volumes/Data/worker/ios-simulator-15-debug-tests-wk2/build/layout-test-results/http/tests/events/device-orientation-motion-non-secure-context-expected.txt
+++ /Volumes/Data/worker/ios-simulator-15-debug-tests-wk2/build/layout-test-results/http/tests/events/device-orientation-motion-non-secure-context-actual.txt
@@ -6,11 +6,12 @@
 
 
 * Registering device orientation listener
-PASS lastConsoleMessage is "No device orientation events will be fired, reason: Browsing context is not secure."
+FAIL lastConsoleMessage should be No device orientation events will be fired, reason: Browsing context is not secure. (of type string). Was null (of type object).
 
 * Registering device motion listener
-PASS lastConsoleMessage is "No device motion events will be fired, reason: Browsing context is not secure."
+FAIL lastConsoleMessage should be No device motion events will be fired, reason: Browsing context is not secure. (of type string). Was null (of type object).
 PASS successfullyParsed is true
+Some tests failed.
 
 TEST COMPLETE
 
DIFF-URL:
https://build.webkit.org/results/Apple-iOS-15-Simulator-Debug-WK2-Tests/r290384%20(1710)/http/tests/events/device-orientation-motion-non-secure-context-diff.txt

[Radar WebKit Bug Importer]

<rdar://problem/89380424>

[Dawn Morningstar]

Failure was reproduced at iOS production TOT using:
run-webkit-tests http/tests/events/device-orientation-motion-non-secure-context.html

History shows regression range between r290344-r290348.
https://results.webkit.org/?suite=layout-tests&test=http%2Ftests%2Fevents%2Fdevice-orientation-motion-non-secure-context.html

Test passed successfully locally on iOS at r290343.

[Dawn Morningstar]

Test was passed locally at iOS r290346, and failed locally at iOS r290348. Narrowing regression point.

[Dawn Morningstar]

I believe regression point is r290348 due to modification of line: 

2113	        printWarningMessage(makeString("No device orientation events will be fired, reason: ", innerMessage, "."));

[Darin Adler]

The problem seems to be that "lastConsoleMessage" does not see this warning message now.

[Dawn Morningstar]

Marking as resolved fixed with this revert: https://trac.webkit.org/changeset/290399/webkit