Bug 237109

Summary: [WebAuthn] Use default pubKeyCredParams if empty in makeCredential
Product: WebKit Reporter: pascoe <pascoe>
Component: WebKit Misc.Assignee: pascoe <pascoe>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, ews-watchlist, jiewen_tan, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 235421    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch
none
Patch for landing
none
Patch for landing
none
Patch for landing
none
Patch for landing
none
Patch for landing none

pascoe@apple.com
Reported 2022-02-23 13:58:19 PST
WebAuthn level 2 spec updated step 10 of make credential to use a set of default pubKeyCredParams if the list is empty.
Attachments
Patch (5.91 KB, patch)
2022-02-23 14:41 PST, pascoe@apple.com 		no flags
DetailsFormatted DiffDiff
Patch (7.38 KB, patch)
2022-02-23 16:07 PST, pascoe@apple.com 		no flags
DetailsFormatted DiffDiff
Patch for landing (7.41 KB, patch)
2022-02-23 16:33 PST, pascoe@apple.com 		no flags
DetailsFormatted DiffDiff
Patch for landing (7.42 KB, patch)
2022-02-24 12:49 PST, pascoe@apple.com 		no flags
DetailsFormatted DiffDiff
Patch for landing (11.14 KB, patch)
2022-02-24 16:22 PST, pascoe@apple.com 		no flags
DetailsFormatted DiffDiff
Patch for landing (10.48 KB, patch)
2022-02-24 19:04 PST, pascoe@apple.com 		no flags
DetailsFormatted DiffDiff
Patch for landing (10.48 KB, patch)
2022-02-25 08:50 PST, pascoe@apple.com 		no flags
DetailsFormatted DiffDiff
Show Obsolete (6) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2022-02-23 13:58:31 PST
<rdar://problem/89376484>
pascoe@apple.com
Comment 2 2022-02-23 14:41:29 PST
Created attachment 453030 [details] Patch
pascoe@apple.com
Comment 3 2022-02-23 16:07:20 PST
Created attachment 453044 [details] Patch
Brent Fulgham
Comment 4 2022-02-23 16:27:14 PST
Comment on attachment 453044 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=453044&action=review Nice! r=me > Source/WebCore/ChangeLog:8 > + The Web Authentication level 2 spec added that a set of default pubKeyCredParams "level 2 spec was updated to clarify that a set of default pubKeyCredParams should be used if the list supplied by the RP is empty."
pascoe@apple.com
Comment 5 2022-02-23 16:33:21 PST
Created attachment 453051 [details] Patch for landing
pascoe@apple.com
Comment 6 2022-02-24 12:49:09 PST
Created attachment 453129 [details] Patch for landing
pascoe@apple.com
Comment 7 2022-02-24 16:22:45 PST
Created attachment 453150 [details] Patch for landing
pascoe@apple.com
Comment 8 2022-02-24 19:04:49 PST
Created attachment 453166 [details] Patch for landing
EWS
Comment 9 2022-02-25 08:34:43 PST
ChangeLog entry in LayoutTests/ChangeLog contains OOPS!.
pascoe@apple.com
Comment 10 2022-02-25 08:50:12 PST
Created attachment 453222 [details] Patch for landing
EWS
Comment 11 2022-02-25 10:46:03 PST
Committed r290515 (?): <https://commits.webkit.org/r290515> All reviewed patches have been landed. Closing bug and clearing flags on attachment 453222 [details].
Brent Fulgham
Comment 12 2022-05-26 14:44:40 PDT
This fix shipped with Safari 15.5 (all platforms).
Note You need to log in before you can comment on or make changes to this bug.