Bug 237070

Summary:

REGRESSION (r289495): Flaky crash under WebKit::ModelElementController::modelElementSizeDidChange()

Product:

WebKit

Reporter:

Ryan Haddad <ryanhaddad>

Component:

New Bugs

Assignee:

Cameron McCormack (:heycam) <heycam>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

graouts, heycam, simon.fraser, webkit-bot-watchers-bugzilla, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
crash log	none
re-enable model tests	none
re-enable model tests (2)	none

Ryan Haddad

Reported 2022-02-22 17:15:52 PST

Created attachment 452922 [details] crash log After https://commits.webkit.org/247033@main landed, model-element/model-element-interactive.html has been frequently crashing on Monterey Debug WK2 bots Thread 0 Crashed: 0 libsystem_kernel.dylib 0x19ae359b8 __pthread_kill + 8 1 libsystem_pthread.dylib 0x19ae6915c 0x19ae62000 + 29020 2 libsystem_c.dylib 0x19ada6314 0x19ad2d000 + 496404 3 libsystem_c.dylib 0x19ada572c 0x19ad2d000 + 493356 4 QuartzCore 0x1a1f1945c -[CAFenceHandle dealloc] + 156 5 WebKit 0x147f08de8 WTF::RetainPtr<CAFenceHandle>::~RetainPtr() + 56 (RetainPtr.h:178) 6 WebKit 0x147f06e90 WTF::RetainPtr<CAFenceHandle>::~RetainPtr() + 28 (RetainPtr.h:176) 7 WebKit 0x147f08d80 WebKit::ModelElementController::modelElementSizeDidChange(WTF::String const&, WebCore::FloatSize, WTF::CompletionHandler<void (std::experimental::fundamentals_v3::expected<WTF::MachSendRight, WebCore::ResourceError>)>&&)::$_12::operator()(CAFenceHandle*, NSError*)::'lambda0'()::~() + 32 (ModelElementControllerCocoa.mm:268) 8 WebKit 0x147f06e64 WebKit::ModelElementController::modelElementSizeDidChange(WTF::String const&, WebCore::FloatSize, WTF::CompletionHandler<void (std::experimental::fundamentals_v3::expected<WTF::MachSendRight, WebCore::ResourceError>)>&&)::$_12::operator()(CAFenceHandle*, NSError*)::'lambda0'()::~() + 28 (ModelElementControllerCocoa.mm:268) 9 WebKit 0x147f08688 WTF::Detail::CallableWrapper<WebKit::ModelElementController::modelElementSizeDidChange(WTF::String const&, WebCore::FloatSize, WTF::CompletionHandler<void (std::experimental::fundamentals_v3::expected<WTF::MachSendRight, WebCore::ResourceError>)>&&)::$_12::operator()(CAFenceHandle*, NSError*)::'lambda0'(), void>::~CallableWrapper() + 48 (Function.h:47) 10 WebKit 0x147f08510 WTF::Detail::CallableWrapper<WebKit::ModelElementController::modelElementSizeDidChange(WTF::String const&, WebCore::FloatSize, WTF::CompletionHandler<void (std::experimental::fundamentals_v3::expected<WTF::MachSendRight, WebCore::ResourceError>)>&&)::$_12::operator()(CAFenceHandle*, NSError*)::'lambda0'(), void>::~CallableWrapper() + 28 (Function.h:47) 11 WebKit 0x147f0853c WTF::Detail::CallableWrapper<WebKit::ModelElementController::modelElementSizeDidChange(WTF::String const&, WebCore::FloatSize, WTF::CompletionHandler<void (std::experimental::fundamentals_v3::expected<WTF::MachSendRight, WebCore::ResourceError>)>&&)::$_12::operator()(CAFenceHandle*, NSError*)::'lambda0'(), void>::~CallableWrapper() + 28 (Function.h:47) https://results.webkit.org/?suite=layout-tests&test=model-element%2Fmodel-element-interactive.html

Attachments
crash log (18.32 KB, text/plain) 2022-02-22 17:15 PST, Ryan Haddad	no flags	Details
re-enable model tests (950 bytes, patch) 2022-11-28 14:44 PST, Cameron McCormack (:heycam)	no flags	Details Formatted Diff Diff
re-enable model tests (2) (950 bytes, patch) 2022-11-29 09:13 PST, Cameron McCormack (:heycam)	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2022-02-22 17:16:04 PST

<rdar://problem/89325947>

Cameron McCormack (:heycam)

Comment 2 2022-11-28 14:44:37 PST

Created attachment 463770 [details] re-enable model tests For an EWS run.

Cameron McCormack (:heycam)

Comment 3 2022-11-29 09:13:15 PST

Created attachment 463788 [details] re-enable model tests (2)

Cameron McCormack (:heycam)

Comment 4 2022-11-30 10:43:25 PST

Pull request: https://github.com/WebKit/WebKit/pull/6975

EWS

Comment 5 2022-12-01 09:31:10 PST

Committed 257243@main (808fe7d3ce99): <https://commits.webkit.org/257243@main> Reviewed commits have been landed. Closing PR #6975 and removing active labels.

Note You need to log in before you can comment on or make changes to this bug.