Bug 237069

Summary: REGRESSION (288925?): [iOS] TestWebKitAPI.RequestTextInputContext.TextInteraction_FocusingReadOnlyElementShouldScrollToReveal is failing
Product: WebKit Reporter: Ryan Haddad <ryanhaddad>
Component: Tools / TestsAssignee: Wenson Hsieh <wenson_hsieh>
Status: RESOLVED FIXED    
Severity: Normal CC: akeerthi, hi, katherine_cheney, megan_gardner, thorton, webkit-bot-watchers-bugzilla, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Repro?
none
Speculative fix none

Ryan Haddad
Reported 2022-02-22 17:03:25 PST
TestWebKitAPI.RequestTextInputContext.TextInteraction_FocusingReadOnlyElementShouldScrollToReveal has been pretty consistently failing on iOS bots since r288941. The regression appears to be somewhere in this range: https://github.com/WebKit/WebKit/compare/69ae9efe43bc4931906b774dcd44265ab2f542bb...505f6ed4699de698ff288413c7a61cb4e07ba9fa TestWebKitAPI.RequestTextInputContext.TextInteraction_FocusingReadOnlyElementShouldScrollToReveal 2022-02-22 13:54:40.416 TestWebKitAPI[70971:37875135] Writing analzed variants. 2022-02-22 13:54:40.432 TestWebKitAPI[70971:37875135] Writing analzed variants. LEAK: 1 WebProcessPool LEAK: 1 WebPageProxy /Volumes/Data/worker/ios-simulator-15-debug/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:667 Value of: didScroll Actual: false Expected: true https://results.webkit.org/?suite=api-tests&test=TestWebKitAPI.RequestTextInputContext.TextInteraction_FocusingReadOnlyElementShouldScrollToReveal
Attachments
Repro? (23.83 KB, patch)
2022-02-22 18:31 PST, Wenson Hsieh 		no flags
DetailsFormatted DiffDiff
Speculative fix (2.64 KB, patch)
2022-02-23 10:48 PST, Wenson Hsieh 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2022-02-22 17:03:41 PST
<rdar://problem/89325305>
Wenson Hsieh
Comment 2 2022-02-22 17:08:01 PST
At a glance, nothing in that range sticks out to me as the culprit. I'll take a closer look...
Wenson Hsieh
Comment 3 2022-02-22 18:31:38 PST
Created attachment 452925 [details] Repro?
Wenson Hsieh
Comment 4 2022-02-22 18:32:44 PST
(In reply to Wenson Hsieh from comment #3) > Created attachment 452925 [details] > Repro? I wasn't able to reproduce this failure locally; going to see if EWS can catch it at least once in 200 runs.
Wenson Hsieh
Comment 5 2022-02-23 10:23:22 PST
(In reply to Wenson Hsieh from comment #4) > (In reply to Wenson Hsieh from comment #3) > > Created attachment 452925 [details] > > Repro? > > I wasn't able to reproduce this failure locally; going to see if EWS can > catch it at least once in 200 runs. Looking at https://ews-build.webkit.org/#/builders/9/builds/65529/steps/14/logs/stdio, it seems all 200 of the TextInteraction_FocusingReadOnlyElementShouldScrollToReveal_* tests passed.
Wenson Hsieh
Comment 6 2022-02-23 10:48:42 PST
Created attachment 453000 [details] Speculative fix
Wenson Hsieh
Comment 7 2022-02-23 12:34:28 PST
Comment on attachment 453000 [details] Speculative fix Thanks for the review!
EWS
Comment 8 2022-02-23 12:58:49 PST
Committed r290389 (247704@main): <https://commits.webkit.org/247704@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 453000 [details].
Note You need to log in before you can comment on or make changes to this bug.