Bug 237040

Summary: Share more code between dispatchSessionStorageEvents() and dispatchLocalStorageEvents()
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebCore Misc.Assignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, darin, ggaren, sihui_liu, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=236985
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch none

Chris Dumez
Reported 2022-02-22 08:10:58 PST
Share more code between dispatchSessionStorageEvents() and dispatchLocalStorageEvents().
Attachments
Patch (6.61 KB, patch)
2022-02-22 08:16 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (36.74 KB, patch)
2022-02-22 11:54 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (6.70 KB, patch)
2022-02-22 12:09 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (6.67 KB, patch)
2022-02-22 16:16 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2022-02-22 08:16:56 PST
Created attachment 452872 [details] Patch
Chris Dumez
Comment 2 2022-02-22 11:54:52 PST
Created attachment 452889 [details] Patch
Chris Dumez
Comment 3 2022-02-22 12:09:49 PST
Created attachment 452891 [details] Patch
Geoffrey Garen
Comment 4 2022-02-22 14:19:31 PST
Comment on attachment 452891 [details] Patch r=me
Darin Adler
Comment 5 2022-02-22 14:59:18 PST
Comment on attachment 452891 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=452891&action=review > Source/WebCore/storage/StorageEventDispatcher.cpp:52 > + if (!isRelevantPage(window.page())) Love this the way it is already, but one note: Could put the null check in the shared code and pass a Page& to the function.
Chris Dumez
Comment 6 2022-02-22 16:16:37 PST
Created attachment 452911 [details] Patch
EWS
Comment 7 2022-02-22 17:35:16 PST
Committed r290342 (247662@main): <https://commits.webkit.org/247662@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 452911 [details].
Radar WebKit Bug Importer
Comment 8 2022-02-22 17:36:21 PST
<rdar://problem/89326846>
Note You need to log in before you can comment on or make changes to this bug.