Bug 237036

Summary: [IFC][Integration] LineLayout::firstInlineBoxRect should flip the rect coordinates for vertical-rl
Product: WebKit Reporter: alan <zalan>
Component: Layout and RenderingAssignee: alan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, darin, koivisto, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
[fast-cq]Patch none

alan
Reported 2022-02-22 06:26:59 PST
ssia
Attachments
Patch (2.29 KB, patch)
2022-02-22 06:39 PST, alan 		no flags
DetailsFormatted DiffDiff
[fast-cq]Patch (2.34 KB, patch)
2022-02-23 09:20 PST, alan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
alan
Comment 1 2022-02-22 06:39:47 PST
Created attachment 452866 [details] Patch
Darin Adler
Comment 2 2022-02-22 09:49:39 PST
Comment on attachment 452866 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=452866&action=review > Source/WebCore/layout/integration/LayoutIntegrationLineLayout.cpp:580 > + firstBoxRect.setX(flow().width() - firstBoxRect.width() - firstBoxRect.x()); This is better: firstBoxRect.setX(flow().width() - firstBoxRect.maxX()); Also, I think we should switch on writingMode rather than using if statements.
alan
Comment 3 2022-02-23 09:20:35 PST
Created attachment 452989 [details] [fast-cq]Patch
EWS
Comment 4 2022-02-23 10:28:06 PST
Committed r290382 (247697@main): <https://commits.webkit.org/247697@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 452989 [details].
Radar WebKit Bug Importer
Comment 5 2022-02-23 10:29:20 PST
<rdar://problem/89364260>
Note You need to log in before you can comment on or make changes to this bug.