Bug 237026
| Summary: | WTF::ThreadAssertion is not useful as most of the code is run with a WorkQueue | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Kimmo Kinnunen <kkinnunen> |
| Component: | Web Template Framework | Assignee: | Kimmo Kinnunen <kkinnunen> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | Other | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Bug Depends on: | 236832 | ||
| Bug Blocks: | |||
Kimmo Kinnunen
WTF::ThreadAssertion is not useful as most of the code is run with a WorkQueue
ThreadAssertion cannot be used with WorkQueues because a WorkQueue might run its runnables in multiple different threads. On Cocoa this happens via thread of a thread pool for Dispatch dispatch queue.
We should have an assertion that can assert that the object is manipulated in the expected sequence, where sequence means either work queue or thread.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/89608226>
Kimmo Kinnunen
Pull request: https://github.com/WebKit/WebKit/pull/4974
Kimmo Kinnunen
Pull request: https://github.com/WebKit/WebKit/pull/5020
EWS
Committed 255274@main (8ed46d3dd638): <https://commits.webkit.org/255274@main>
Reviewed commits have been landed. Closing PR #5020 and removing active labels.