Bug 236971 – [GTK][WPE] Suspend web process after some time in the process cache

• Component: WebKitGTK
• Status: RESOLVED FIXED

[Carlos Garcia Campos]

And resume them when they are restored

[Carlos Garcia Campos]

Created attachment 452728 [details]
Patch

[Michael Catanzaro]

Comment on attachment 452728 [details]
Patch

What could go wrong? :)

[Michael Catanzaro]

Comment on attachment 452728 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=452728&action=review

> Source/WebKit/UIProcess/glib/WebProcessProxyGLib.cpp:81
> +void WebProcessProxy::platformSuspendProcess()
> +{
> +    auto id = processIdentifier();
> +    if (!id)
> +        return;
> +
> +    RELEASE_LOG(Process, "%p - [PID=%i] WebProcessProxy::platformSuspendProcess", this, id);
> +    kill(id, SIGSTOP);
> +}

Since there is nothing GTK/WPE-specific here, I think I would move this to a WebProcessProxyUnix.cpp and guard it with #if !PLATFORM(COCOA). Then instead of #if PLATFORM(MAC) || PLATFORM(GTK) || PLATFORM(WPE) guards, you would only need to use #if PLATFORM(MAC) || OS(UNIX) guards instead.

Um, is OS(UNIX) true for PLATFORM(IOS_FAMILY)? I'm not sure. Got to be careful about that, if so.

[Carlos Garcia Campos]

Committed r290291 (247615@trunk): <https://commits.webkit.org/247615@trunk>