Bug 236936

Summary: [JSC] Temporal.PlainDate should validate input range
Product: WebKit Reporter: Yusuke Suzuki <ysuzuki>
Component: New BugsAssignee: Yusuke Suzuki <ysuzuki>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, cdumez, cmarcelo, darin, ews-watchlist, keith_miller, mark.lam, msaboff, saam, tzagallo, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
ews-feeder: commit-queue-
Patch
ews-feeder: commit-queue-
Patch darin: review+

Yusuke Suzuki
Reported 2022-02-20 01:41:22 PST
[JSC] Temporal.PlainDate should validate input range
Attachments
Patch (11.80 KB, patch)
2022-02-20 01:46 PST, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
Patch (14.28 KB, patch)
2022-02-21 14:44 PST, Yusuke Suzuki 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (14.98 KB, patch)
2022-02-21 14:54 PST, Yusuke Suzuki 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (14.57 KB, patch)
2022-02-21 15:09 PST, Yusuke Suzuki 		darin: review+
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Yusuke Suzuki
Comment 1 2022-02-20 01:46:16 PST
Created attachment 452687 [details] Patch
Darin Adler
Comment 2 2022-02-21 12:57:42 PST
Comment on attachment 452687 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=452687&action=review > JSTests/ChangeLog:3 > + [JSC] Temporal.PlainDate should validate input range I think we’d want the test for the last valid as well as the first invalid.
Yusuke Suzuki
Comment 3 2022-02-21 14:43:50 PST
Comment on attachment 452687 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=452687&action=review >> JSTests/ChangeLog:3 >> + [JSC] Temporal.PlainDate should validate input range > > I think we’d want the test for the last valid as well as the first invalid. Sounds good, added.
Yusuke Suzuki
Comment 4 2022-02-21 14:44:26 PST
Created attachment 452776 [details] Patch
Yusuke Suzuki
Comment 5 2022-02-21 14:54:48 PST
Created attachment 452778 [details] Patch
Yusuke Suzuki
Comment 6 2022-02-21 15:09:27 PST
Created attachment 452781 [details] Patch
Darin Adler
Comment 7 2022-02-21 16:58:25 PST
Comment on attachment 452781 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=452781&action=review review+ assuming the tests pass > JSTests/stress/temporal-plaindate.js:114 > +new Temporal.PlainDate(0x43530, 9, 13); Maybe a shouldBe about the string form? > JSTests/stress/temporal-plaindate.js:116 > +new Temporal.PlainDate(-0x425cd, 4, 20); Ditto.
Yusuke Suzuki
Comment 8 2022-02-21 18:07:50 PST
Comment on attachment 452781 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=452781&action=review Thank you! >> JSTests/stress/temporal-plaindate.js:114 >> +new Temporal.PlainDate(0x43530, 9, 13); > > Maybe a shouldBe about the string form? Done. >> JSTests/stress/temporal-plaindate.js:116 >> +new Temporal.PlainDate(-0x425cd, 4, 20); > > Ditto. Done.
Yusuke Suzuki
Comment 9 2022-02-21 18:12:32 PST
Committed r290282 (?): <https://commits.webkit.org/r290282>
Radar WebKit Bug Importer
Comment 10 2022-02-21 18:13:15 PST
<rdar://problem/89268246>
Note You need to log in before you can comment on or make changes to this bug.