[GPU Process] Text filled with pattern sometimes draw with incorrect color

• Component: WebKit Process Model
• Status: RESOLVED FIXED

[Jon Lee]

imported/mozilla/svg/linearGradient-basic-03.svg [ ImageOnlyFailure ]
imported/mozilla/svg/pattern-transformed-01.svg [ ImageOnlyFailure ]
svg/gradients/gradient-flipped-start-end-points.svg [ ImageOnlyFailure ]
svg/gradients/spreadMethod.svg [ ImageOnlyFailure ]
svg/gradients/spreadMethodAlpha.svg [ ImageOnlyFailure ]
svg/gradients/spreadMethodDiagonal.svg [ ImageOnlyFailure ]
svg/gradients/spreadMethodDiagonal2.svg [ ImageOnlyFailure ]
svg/gradients/spreadMethodDiagonal3.svg [ ImageOnlyFailure ]
svg/gradients/spreadMethodDiagonal4.svg [ ImageOnlyFailure ]
svg/gradients/spreadMethodDuplicateStop.svg [ ImageOnlyFailure ]
svg/gradients/spreadMethodReversed.svg [ ImageOnlyFailure ]
svg/gradients/stopAlpha.svg [ ImageOnlyFailure ]
svg/transforms/transformed-text-fill-gradient.html [ ImageOnlyFailure ]
svg/transforms/transformed-text-fill-pattern.html [ ImageOnlyFailure ]

[Radar WebKit Bug Importer]

<rdar://problem/89196811>

[Jon Lee]

The patch for bug 237728 resolves imported/mozilla/svg/linearGradient-basic-03.svg and svg/gradients/gradient-flipped-start-end-points.svg, and svg/transforms/transformed-text-fill-pattern.html turns into a crash.

[Said Abou-Hallawa]

Created attachment 456066 [details]
Patch

[Said Abou-Hallawa]

Created attachment 456596 [details]
Patch

[Myles C. Maxfield]

Comment on attachment 456596 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=456596&action=review

> Source/WebCore/platform/graphics/coretext/DrawGlyphsRecorderCoreText.cpp:152
> +        return;

Can we at least set it to a hardcoded color in this case? So it doesn't get filled with some random previously-used color?

> Source/WebCore/platform/graphics/coretext/DrawGlyphsRecorderCoreText.cpp:164
> +        return;

Ditto.

[Myles C. Maxfield]

Comment on attachment 456596 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=456596&action=review

>> Source/WebCore/platform/graphics/coretext/DrawGlyphsRecorderCoreText.cpp:152
>> +        return;
> 
> Can we at least set it to a hardcoded color in this case? So it doesn't get filled with some random previously-used color?

Actually, maybe it's better to ASSERT() the return of CGColorGetPattern() is equal to the pattern that was set on the context before recording any glyphs.

[Said Abou-Hallawa]

Created attachment 456788 [details]
Patch

[EWS]

Committed r292478 (249329@main): <https://commits.webkit.org/249329@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 456788 [details].