Bug 23691

Summary:

REGRESSION: New GraphicsContextCGWin members needed in all Windows builds.

Product:

WebKit

Reporter:

Brent Fulgham <bfulgham>

Component:

WebCore Misc.

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aroben

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

Windows XP

Bug Depends on:

23623

Bug Blocks:

Attachments:

Description	Flags
Move common code up in the hierarchy to clean up implementation and resolve build issue.	staikos: review+

Brent Fulgham

Reported 2009-02-02 12:29:54 PST

Fix for 23623 added two new methods (setShouldIncludeChildWindows and shouldIncludeChildWindows) to the GraphicsContext for Windows builds, but only defined them for the CG Windows build. This patch moves the implementation from GraphicsContextCG to GraphicsContextWin, where the Cairo and CG builds can use them.

Attachments
Move common code up in the hierarchy to clean up implementation and resolve build issue. (3.86 KB, patch) 2009-02-02 13:14 PST, Brent Fulgham	staikos: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Brent Fulgham

Comment 1 2009-02-02 13:14:21 PST

Created attachment 27257 [details] Move common code up in the hierarchy to clean up implementation and resolve build issue.

Brent Fulgham

Comment 2 2009-02-02 13:36:04 PST

Committed in r40490.

Note You need to log in before you can comment on or make changes to this bug.