Bug 236902

Summary:

[WebGPU] Tracer bullet part 8: Basic implementation of device creation routines

Product:

WebKit

Reporter:

Myles C. Maxfield <mmaxfield>

Component:

WebGPU

Assignee:

Myles C. Maxfield <mmaxfield>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

dino, rmorisset, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

236879

Attachments:

Description	Flags
Patch	dino: review+

Description Myles C. Maxfield 2022-02-19 20:32:54 PST

This is a basic implementation of the Instance, Adapter, and Device methods. Device limits are not implemented yet, so for now we claim every limits is 0.

Comment 1 Myles C. Maxfield 2022-02-19 20:34:33 PST

Created attachment 452668 [details]
Patch

Comment 2 Dean Jackson 2022-02-21 09:29:41 PST

Comment on attachment 452668 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=452668&action=review

> Source/WebGPU/ChangeLog:9
> +        implemented yet, so for now we claim every limits is 0.

typo: limits

> Source/WebGPU/WebGPU/Adapter.mm:63
> +    properties->driverDescription = "";

Not emptyString()?

Comment 3 Myles C. Maxfield 2022-02-21 12:49:11 PST

Committed r290262 (?): <https://commits.webkit.org/r290262>

Comment 4 Radar WebKit Bug Importer 2022-02-21 12:50:22 PST

<rdar://problem/89251773>