Bug 236901

Summary: Origin file may not be created after migrating data to general storage directory
Product: WebKit Reporter: Sihui Liu <sihui_liu>
Component: Website StorageAssignee: Sihui Liu <sihui_liu>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, sihui_liu, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
ews-feeder: commit-queue-
Patch
none
Patch for landing
none
Patch for landing none

Description Sihui Liu 2022-02-19 20:24:26 PST
...
Comment 1 Sihui Liu 2022-02-19 21:05:57 PST
Created attachment 452673 [details]
Patch
Comment 2 Sihui Liu 2022-02-19 21:24:14 PST
Created attachment 452676 [details]
Patch
Comment 3 Chris Dumez 2022-02-19 23:31:23 PST
Comment on attachment 452676 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=452676&action=review

R=me

> Source/WebKit/ChangeLog:18
> +        old behavior that synchronouly writes origin file at creation of OriginStorageManager. To sovle the delay issue,

Typo: solve

> Source/WebKit/ChangeLog:19
> +        in the sync message handler (NetworkStorageManager::connectToStorageArea), we specifically asks to not write 

Typo: ask

> Source/WebKit/NetworkProcess/storage/NetworkStorageManager.cpp:726
> +    // Avoid delay in replying sync message by delay writing origin to file.

By delaying
Comment 4 Sihui Liu 2022-02-20 13:12:24 PST
Created attachment 452698 [details]
Patch for landing
Comment 5 Sihui Liu 2022-02-20 13:12:51 PST
Created attachment 452699 [details]
Patch for landing
Comment 6 EWS 2022-02-20 15:11:08 PST
Committed r290233 (247558@main): <https://commits.webkit.org/247558@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 452699 [details].
Comment 7 Radar WebKit Bug Importer 2022-02-20 15:12:19 PST
<rdar://problem/89209181>