Bug 236835 – [LFC][Integration] Add missing LineIteratorModernPath::isHorizontal implementation

• Component: Layout and Rendering
• Status: RESOLVED FIXED

[zalan]

ssia

[zalan]

Created attachment 452511 [details]
Patch

[Antti Koivisto]

Comment on attachment 452511 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=452511&action=review

> Source/WebCore/layout/formattingContexts/inline/display/InlineDisplayLine.h:80
> +    bool m_isHorizontal { true };

This might not really need a bit since it is always same for all lines within a block?

[zalan]

(In reply to Antti Koivisto from comment #2)
> Comment on attachment 452511 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=452511&action=review
> 
> > Source/WebCore/layout/formattingContexts/inline/display/InlineDisplayLine.h:80
> > +    bool m_isHorizontal { true };
> 
> This might not really need a bit since it is always same for all lines
> within a block?
Yeah, we should definitely come back to it when all the vertical modes are enabled and see if we could just grab it off of the IFC root.

[EWS]

Committed r290127 (247471@main): <https://commits.webkit.org/247471@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 452511 [details].

[Radar WebKit Bug Importer]

<rdar://problem/89146753>