Summary: | [LFC][Integration] Add missing LineIteratorModernPath::isHorizontal implementation | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | zalan <zalan> | ||||
Component: | Layout and Rendering | Assignee: | zalan <zalan> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | bfulgham, koivisto, simon.fraser, webkit-bug-importer, zalan | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | WebKit Nightly Build | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
zalan
2022-02-18 05:02:14 PST
Created attachment 452511 [details]
Patch
Comment on attachment 452511 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=452511&action=review > Source/WebCore/layout/formattingContexts/inline/display/InlineDisplayLine.h:80 > + bool m_isHorizontal { true }; This might not really need a bit since it is always same for all lines within a block? (In reply to Antti Koivisto from comment #2) > Comment on attachment 452511 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=452511&action=review > > > Source/WebCore/layout/formattingContexts/inline/display/InlineDisplayLine.h:80 > > + bool m_isHorizontal { true }; > > This might not really need a bit since it is always same for all lines > within a block? Yeah, we should definitely come back to it when all the vertical modes are enabled and see if we could just grab it off of the IFC root. Committed r290127 (247471@main): <https://commits.webkit.org/247471@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 452511 [details]. |