Bug 236815

Summary: [macOS] Allow screen and window capture to be done in the GPU Process
Product: WebKit Reporter: Eric Carlson <eric.carlson>
Component: WebRTCAssignee: Eric Carlson <eric.carlson>
Status: RESOLVED FIXED    
Severity: Normal CC: ews-watchlist, glenn, hta, jer.noble, philipj, sergio, tommyw, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
[fast-cq] Patch for landing none

Eric Carlson
Reported 2022-02-17 17:07:49 PST
Add an experimental feature to do screen and window capture in the GPU Process
Attachments
Patch (51.40 KB, patch)
2022-02-17 17:57 PST, Eric Carlson 		no flags
DetailsFormatted DiffDiff
Patch (50.46 KB, patch)
2022-02-17 21:55 PST, Eric Carlson 		no flags
DetailsFormatted DiffDiff
[fast-cq] Patch for landing (50.87 KB, patch)
2022-02-18 04:47 PST, Eric Carlson 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2022-02-17 17:08:00 PST
<rdar://problem/89117278>
Eric Carlson
Comment 2 2022-02-17 17:57:15 PST
Created attachment 452459 [details] Patch
Jer Noble
Comment 3 2022-02-17 21:25:05 PST
Comment on attachment 452459 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=452459&action=review r=me with a small nit, once the bots are green > Source/WebCore/platform/mediastream/mac/ScreenCaptureKitCaptureSource.mm:377 > + ALWAYS_LOG_IF(loggerPtr(), LOGIDENTIFIER); I think this can be ALWAYS_LOG_IF_POSSIBLE(LOGIDENTIFIER) > Source/WebCore/platform/mediastream/mac/ScreenCaptureKitCaptureSource.mm:403 > + ALWAYS_LOG_IF(loggerPtr(), LOGIDENTIFIER); Ditto
Eric Carlson
Comment 4 2022-02-17 21:55:03 PST
Created attachment 452478 [details] Patch
Eric Carlson
Comment 5 2022-02-18 04:47:24 PST
Created attachment 452508 [details] [fast-cq] Patch for landing
Eric Carlson
Comment 6 2022-02-18 07:55:01 PST
Comment on attachment 452508 [details] [fast-cq] Patch for landing The windows failure is unrelated
EWS
Comment 7 2022-02-18 13:03:27 PST
Found 1 new test failure: fast/sandbox/mac/sandbox-mach-lookup.html
Eric Carlson
Comment 8 2022-02-18 13:41:38 PST
Comment on attachment 452508 [details] [fast-cq] Patch for landing Per Arne and I can't see anything in this that could break fast/sandbox/mac/sandbox-mach-lookup.html
EWS
Comment 9 2022-02-18 14:44:47 PST
Committed r290174 (247505@main): <https://commits.webkit.org/247505@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 452508 [details].
Note You need to log in before you can comment on or make changes to this bug.