Bug 236815

Summary: [macOS] Allow screen and window capture to be done in the GPU Process
Product: WebKit Reporter: Eric Carlson <eric.carlson>
Component: WebRTCAssignee: Eric Carlson <eric.carlson>
Status: RESOLVED FIXED    
Severity: Normal CC: ews-watchlist, glenn, hta, jer.noble, philipj, sergio, tommyw, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
[fast-cq] Patch for landing none

Description Eric Carlson 2022-02-17 17:07:49 PST 
Add an experimental feature to do screen and window capture in the GPU Process
Comment 1 Radar WebKit Bug Importer 2022-02-17 17:08:00 PST 
<rdar://problem/89117278>
Comment 2 Eric Carlson 2022-02-17 17:57:15 PST 
Created attachment 452459 [details]
Patch
Comment 3 Jer Noble 2022-02-17 21:25:05 PST 
Comment on attachment 452459 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=452459&action=review

r=me with a small nit, once the bots are green

> Source/WebCore/platform/mediastream/mac/ScreenCaptureKitCaptureSource.mm:377
> +    ALWAYS_LOG_IF(loggerPtr(), LOGIDENTIFIER);

I think this can be ALWAYS_LOG_IF_POSSIBLE(LOGIDENTIFIER)

> Source/WebCore/platform/mediastream/mac/ScreenCaptureKitCaptureSource.mm:403
> +    ALWAYS_LOG_IF(loggerPtr(), LOGIDENTIFIER);

Ditto
Comment 4 Eric Carlson 2022-02-17 21:55:03 PST 
Created attachment 452478 [details]
Patch
Comment 5 Eric Carlson 2022-02-18 04:47:24 PST 
Created attachment 452508 [details]
[fast-cq] Patch for landing
Comment 6 Eric Carlson 2022-02-18 07:55:01 PST 
Comment on attachment 452508 [details]
[fast-cq] Patch for landing

The windows failure is unrelated
Comment 7 EWS 2022-02-18 13:03:27 PST 
Found 1 new test failure: fast/sandbox/mac/sandbox-mach-lookup.html
Comment 8 Eric Carlson 2022-02-18 13:41:38 PST 
Comment on attachment 452508 [details]
[fast-cq] Patch for landing

Per Arne and I can't see anything in this that could break fast/sandbox/mac/sandbox-mach-lookup.html
Comment 9 EWS 2022-02-18 14:44:47 PST 
Committed r290174 (247505@main): <https://commits.webkit.org/247505@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 452508 [details].