[git-webkit] 'IndexError: list index out of range '

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Ryan Haddad]

➜  monarch [~/sources/OpenSource] git-webkit pr
Branch 'main' set up to track remote branch 'main' from 'origin'.
Warning: Permanently added 'github.com' (ED25519) to the list of known hosts.
Warning: Permanently added 'github.com' (ED25519) to the list of known hosts.
From github.com:WebKit/WebKit
 * branch                      main       -> FETCH_HEAD
Current branch eng/236809-dashboard-cleanup is up to date.
Traceback (most recent call last):
  File "/Users/ryan/sources/Internal/Tools/Scripts/git-webkit", line 76, in <module>
    sys.exit(program.main(
  File "/Users/ryan/sources/OpenSource/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/__init__.py", line 134, in main
    return parsed.main(
  File "/Users/ryan/sources/OpenSource/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/pull_request.py", line 163, in main
    if repository.pull(rebase=True, branch=branch_point.branch):
  File "/Users/ryan/sources/OpenSource/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/local/git.py", line 938, in pull
    self.cache.clear(self.branch)
  File "/Users/ryan/sources/OpenSource/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/local/git.py", line 214, in clear
    self._fill(branch)
  File "/Users/ryan/sources/OpenSource/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/local/git.py", line 81, in _fill
    branch_point = int(self._hash_to_identifiers[self._ordered_commits[branch][0]].split('@')[0])
IndexError: list index out of range

[Ryan Haddad]

Created attachment 452445 [details]
identifiers.json file from my machine

[Ryan Haddad]

Moving .git/identifiers.json aside fixed this for me.

I think I cancelled a git operation earlier, so maybe that put it in a bad state.

[Radar WebKit Bug Importer]

<rdar://problem/91307826>

[Jonathan Bedard]

Pull request: https://github.com/WebKit/WebKit/pull/7200

[Jonathan Bedard]

I was finally able to reproduce this issue locally, it's caused by empty branch references being saved (which Ryan's uploaded identifiers.json corroborates). We don't have to throw out the entire cache, we just need to refuse to load empty branch references.

[EWS]

Committed 257505@main (9f6b01dab869): <https://commits.webkit.org/257505@main>

Reviewed commits have been landed. Closing PR #7200 and removing active labels.

[EWS]

Committed 252432.936@safari-7614-branch (b9812d25922f): <https://commits.webkit.org/252432.936@safari-7614-branch>

Reviewed commits have been landed. Closing PR #244 and removing active labels.

[Jonathan Bedard]

*** Bug 240533 has been marked as a duplicate of this bug. ***