Bug 236751 – [Cocoa] Link WebCore with WebGPU.framework 🎉

• Component: New Bugs
• Status: RESOLVED FIXED

[Myles C. Maxfield]

[Cocoa] Link WebCore with WebGPU.framework 🎉

[Myles C. Maxfield]

Created attachment 452312 [details]
Patch

[Myles C. Maxfield]

Comment on attachment 452312 [details]
Patch

I'm not supposed to land this quite yet.

[Myles C. Maxfield]

Comment on attachment 452312 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=452312&action=review

> Source/WTF/wtf/PlatformHave.h:1147
>  #if PLATFORM(COCOA)

This needs to be #if PLATFORM(COCOA) && !CPU(APPLE_ARMV7K)

[Alexey Proskuryakov]

Comment on attachment 452312 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=452312&action=review

> Source/WebCore/Configurations/WebCore.xcconfig:89
> +WK_WEBGPU_LDFLAGS = -weak_framework WebGPU;

Can we actually do this? I didn't think so, because of shared cache.

[Myles C. Maxfield]

Comment on attachment 452312 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=452312&action=review

>> Source/WebCore/Configurations/WebCore.xcconfig:89
>> +WK_WEBGPU_LDFLAGS = -weak_framework WebGPU;
> 
> Can we actually do this? I didn't think so, because of shared cache.

Why not? It's what ANGLE does directly above.

[Alexey Proskuryakov]

Discussed directly, seems fine, but it was worth getting on the same page as to why.

[Myles C. Maxfield]

Comment on attachment 452312 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=452312&action=review

>>> Source/WebCore/Configurations/WebCore.xcconfig:89
>>> +WK_WEBGPU_LDFLAGS = -weak_framework WebGPU;
>> 
>> Can we actually do this? I didn't think so, because of shared cache.
> 
> Why not? It's what ANGLE does directly above.

Instead of doing weak linking, we can use regular linking, but only do it on the relevant operating systems.

[Alexey Proskuryakov]

Except that we apparently do need weak linking on macOS.

[Radar WebKit Bug Importer]

<rdar://problem/89398482>

[Myles C. Maxfield]

Comment on attachment 452312 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=452312&action=review

>> Source/WTF/wtf/PlatformHave.h:1147
>>  #if PLATFORM(COCOA)
> 
> This needs to be #if PLATFORM(COCOA) && !CPU(APPLE_ARMV7K)

Nevermind. WebGPU doesn't require a 64-bit device.

>>>> Source/WebCore/Configurations/WebCore.xcconfig:89
>>>> +WK_WEBGPU_LDFLAGS = -weak_framework WebGPU;
>>> 
>>> Can we actually do this? I didn't think so, because of shared cache.
>> 
>> Why not? It's what ANGLE does directly above.
> 
> Instead of doing weak linking, we can use regular linking, but only do it on the relevant operating systems.

Weak linking is required because of the base system.

[Myles C. Maxfield]

Created attachment 456087 [details]
Patch for committing

[EWS]

Committed r292138 (249045@main): <https://commits.webkit.org/249045@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 456087 [details].