Bug 236745

Summary:

[MacCatalyst] improve support for resizing

Product:

WebKit

Reporter:

Devin Rousso <hi>

Component:

New Bugs

Assignee:

Devin Rousso <hi>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

akeerthi, bdakin, hi, katherine_cheney, megan_gardner, thorton, webkit-bug-importer, wenson_hsieh

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

237126, 240691

Attachments:

Description	Flags
Patch	none

Description Devin Rousso 2022-02-16 17:31:27 PST

Comment 1 Devin Rousso 2022-02-16 17:31:49 PST

<rdar://problem/86494393>

Comment 2 Devin Rousso 2022-02-16 17:56:37 PST

Created attachment 452281 [details]
Patch

Comment 3 EWS 2022-02-17 16:43:33 PST

Committed r290091 (247445@main): <https://commits.webkit.org/247445@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 452281 [details].

Comment 4 Wenson Hsieh 2022-05-19 16:14:08 PDT

Comment on attachment 452281 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=452281&action=review

> Source/WebKit/UIProcess/API/ios/WKWebViewIOS.mm:2013
> +    _resizeAssertions.append(adoptNS([windowScene _holdLiveResizeSnapshotForReason:reason]));

This `adoptNS` looks suspicious.

Comment 5 Devin Rousso 2022-05-19 16:16:10 PDT

Comment on attachment 452281 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=452281&action=review

>> Source/WebKit/UIProcess/API/ios/WKWebViewIOS.mm:2013
>> +    _resizeAssertions.append(adoptNS([windowScene _holdLiveResizeSnapshotForReason:reason]));
> 
> This `adoptNS` looks suspicious.

this was changed in r290442

Comment 6 Wenson Hsieh 2022-05-19 16:17:26 PDT

(In reply to Devin Rousso from comment #5)
> Comment on attachment 452281 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=452281&action=review
> 
> >> Source/WebKit/UIProcess/API/ios/WKWebViewIOS.mm:2013
> >> +    _resizeAssertions.append(adoptNS([windowScene _holdLiveResizeSnapshotForReason:reason]));
> > 
> > This `adoptNS` looks suspicious.
> 
> this was changed in r290442

🤦🏻‍♂️ I didn't look at the date of the patch, and thought it was just uploaded.