Bug 236745

Summary: [MacCatalyst] improve support for resizing
Product: WebKit Reporter: Devin Rousso <hi>
Component: New BugsAssignee: Devin Rousso <hi>
Status: RESOLVED FIXED    
Severity: Normal CC: akeerthi, bdakin, hi, katherine_cheney, megan_gardner, thorton, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 237126, 240691    
Attachments:
Description Flags
Patch none

Devin Rousso
Reported 2022-02-16 17:31:27 PST
.
Attachments
Patch (9.20 KB, patch)
2022-02-16 17:56 PST, Devin Rousso 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Devin Rousso
Comment 1 2022-02-16 17:31:49 PST
<rdar://problem/86494393>
Devin Rousso
Comment 2 2022-02-16 17:56:37 PST
Created attachment 452281 [details] Patch
EWS
Comment 3 2022-02-17 16:43:33 PST
Committed r290091 (247445@main): <https://commits.webkit.org/247445@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 452281 [details].
Wenson Hsieh
Comment 4 2022-05-19 16:14:08 PDT
Comment on attachment 452281 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=452281&action=review > Source/WebKit/UIProcess/API/ios/WKWebViewIOS.mm:2013 > + _resizeAssertions.append(adoptNS([windowScene _holdLiveResizeSnapshotForReason:reason])); This `adoptNS` looks suspicious.
Devin Rousso
Comment 5 2022-05-19 16:16:10 PDT
Comment on attachment 452281 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=452281&action=review >> Source/WebKit/UIProcess/API/ios/WKWebViewIOS.mm:2013 >> + _resizeAssertions.append(adoptNS([windowScene _holdLiveResizeSnapshotForReason:reason])); > > This `adoptNS` looks suspicious. this was changed in r290442
Wenson Hsieh
Comment 6 2022-05-19 16:17:26 PDT
(In reply to Devin Rousso from comment #5) > Comment on attachment 452281 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=452281&action=review > > >> Source/WebKit/UIProcess/API/ios/WKWebViewIOS.mm:2013 > >> + _resizeAssertions.append(adoptNS([windowScene _holdLiveResizeSnapshotForReason:reason])); > > > > This `adoptNS` looks suspicious. > > this was changed in r290442 🤦🏻‍♂️ I didn't look at the date of the patch, and thought it was just uploaded.
Note You need to log in before you can comment on or make changes to this bug.