Bug 236740

Summary: Always use ChildChange::Source::Parser when creating input element UA shadow tree contents
Product: WebKit Reporter: Cameron McCormack (:heycam) <heycam>
Component: FormsAssignee: Cameron McCormack (:heycam) <heycam>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, changseok, dino, esprehn+autocc, ews-watchlist, gyuyoung.kim, mifenton, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Cameron McCormack (:heycam)
Reported 2022-02-16 15:41:48 PST
When creating an input element's UA shadow tree, we currently use a ChildChange::Source value that depends on whether the input element itself was parser- or script-inserted. But since UA shadow trees are not exposed to content, and we don't have any dependency on the extra work that inserting using ChildChange::Source::API does, we can use ChildChange::Source::Parser unconditionally. Local testing showed this scored a 0.1% Speedometer 2 improvement.
Attachments
Patch (18.11 KB, patch)
2022-02-16 15:43 PST, Cameron McCormack (:heycam) 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Cameron McCormack (:heycam)
Comment 1 2022-02-16 15:43:49 PST
Created attachment 452261 [details] Patch
EWS
Comment 2 2022-02-17 16:02:36 PST
Committed r290086 (247441@main): <https://commits.webkit.org/247441@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 452261 [details].
Radar WebKit Bug Importer
Comment 3 2022-02-17 16:03:18 PST
<rdar://problem/89113963>
Note You need to log in before you can comment on or make changes to this bug.