Bug 236717

Summary: Resync web-platform-tests/paint-timing from upstream
Product: WebKit Reporter: Noam Rosenthal <noam>
Component: New BugsAssignee: Noam Rosenthal <noam>
Status: RESOLVED FIXED    
Severity: Normal CC: clopez, eric.carlson, ews-watchlist, glenn, jer.noble, philipj, sergio, simon.fraser, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 225305    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch none

Noam Rosenthal
Reported 2022-02-16 10:38:26 PST
Resync web-platform-tests/paint-timing from upstream
Attachments
Patch (55.94 KB, patch)
2022-02-16 10:38 PST, Noam Rosenthal 		no flags
DetailsFormatted DiffDiff
Patch (61.38 KB, patch)
2022-02-16 10:42 PST, Noam Rosenthal 		no flags
DetailsFormatted DiffDiff
Patch (46.99 KB, patch)
2022-02-16 23:31 PST, Noam Rosenthal 		no flags
DetailsFormatted DiffDiff
Patch (53.57 KB, patch)
2022-02-16 23:55 PST, Noam Rosenthal 		no flags
DetailsFormatted DiffDiff
Patch (49.20 KB, patch)
2022-02-17 10:05 PST, Noam Rosenthal 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Noam Rosenthal
Comment 1 2022-02-16 10:38:41 PST
Created attachment 452210 [details] Patch
EWS Watchlist
Comment 2 2022-02-16 10:40:03 PST
This patch modifies the imported WPT tests. Please ensure that any changes on the tests (not coming from a WPT import) are exported to WPT. Please see https://trac.webkit.org/wiki/WPTExportProcess
Noam Rosenthal
Comment 3 2022-02-16 10:42:50 PST
Created attachment 452211 [details] Patch
Simon Fraser (smfr)
Comment 4 2022-02-16 11:03:24 PST
Comment on attachment 452211 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=452211&action=review > LayoutTests/imported/w3c/web-platform-tests/paint-timing/fcp-only/fcp-background-size.html:21 > +<script src="../../../../../resources/testharness.js"></script> > +<script src="../../../../../resources/testharnessreport.js"></script> These don't seem right. Did you use the script to import? The tests are run via the http server so no need to fix up paths.
Noam Rosenthal
Comment 5 2022-02-16 12:02:34 PST
(In reply to Simon Fraser (smfr) from comment #4) > Comment on attachment 452211 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=452211&action=review > > > LayoutTests/imported/w3c/web-platform-tests/paint-timing/fcp-only/fcp-background-size.html:21 > > +<script src="../../../../../resources/testharness.js"></script> > > +<script src="../../../../../resources/testharnessreport.js"></script> > > These don't seem right. Did you use the script to import? The tests are run > via the http server so no need to fix up paths. Sure used the script, maybe wrong args. Will try again
Noam Rosenthal
Comment 6 2022-02-16 23:31:37 PST
Created attachment 452326 [details] Patch
Noam Rosenthal
Comment 7 2022-02-16 23:33:19 PST
(In reply to Noam Rosenthal from comment #5) > (In reply to Simon Fraser (smfr) from comment #4) > > Comment on attachment 452211 [details] > > Patch > > > > View in context: > > https://bugs.webkit.org/attachment.cgi?id=452211&action=review > > > > > LayoutTests/imported/w3c/web-platform-tests/paint-timing/fcp-only/fcp-background-size.html:21 > > > +<script src="../../../../../resources/testharness.js"></script> > > > +<script src="../../../../../resources/testharnessreport.js"></script> > > > > These don't seem right. Did you use the script to import? The tests are run > > via the http server so no need to fix up paths. > > Sure used the script, maybe wrong args. Will try again Forgot the "-l" when importing from local folder. Should be good now
Noam Rosenthal
Comment 8 2022-02-16 23:55:11 PST
Created attachment 452331 [details] Patch
Simon Fraser (smfr)
Comment 9 2022-02-17 09:28:16 PST
Comment on attachment 452331 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=452331&action=review > LayoutTests/imported/w3c/ChangeLog:7 > + Resync web-platform-tests/paint-timing from upstream > + https://bugs.webkit.org/show_bug.cgi?id=236717 > + > + Reviewed by NOBODY (OOPS!). > + Double changlelog (I prefer the first one with the wpt git hash).
Noam Rosenthal
Comment 10 2022-02-17 10:05:43 PST
Created attachment 452381 [details] Patch
EWS
Comment 11 2022-02-17 15:14:37 PST
Committed r290080 (247436@main): <https://commits.webkit.org/247436@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 452381 [details].
Radar WebKit Bug Importer
Comment 12 2022-02-17 15:15:18 PST
<rdar://problem/89111485>
Note You need to log in before you can comment on or make changes to this bug.