Bug 236704

Summary: RemoteVideoFrameProxy should use RemoteVideoFrameObjectHeapProxy to get the pixel buffer representation
Product: WebKit Reporter: Kimmo Kinnunen <kkinnunen>
Component: New BugsAssignee: Kimmo Kinnunen <kkinnunen>
Status: RESOLVED FIXED    
Severity: Normal CC: eric.carlson, ews-watchlist, glenn, jer.noble, koivisto, philipj, sergio, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
ews-feeder: commit-queue-
Patch
none
Patch for landing none

Description Kimmo Kinnunen 2022-02-16 05:48:02 PST 
RemoteVideoFrameProxy should use RemoteVideoFrameObjectHeapProxy to get the pixel buffer representation
Comment 1 Kimmo Kinnunen 2022-02-16 05:59:00 PST 
Created attachment 452188 [details]
Patch
Comment 2 Kimmo Kinnunen 2022-02-16 06:11:35 PST 
Created attachment 452191 [details]
Patch
Comment 3 Antti Koivisto 2022-02-16 07:23:48 PST 
Comment on attachment 452191 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=452191&action=review

> Source/WebKit/WebProcess/GPU/graphics/RemoteGraphicsContextGLProxy.cpp:181
> +    return RemoteVideoFrameProxy::create(m_gpuProcessConnection->connection(), m_gpuProcessConnection->videoFrameObjectHeapProxy(),  WTFMove(*result));

double space before WTFMove
Comment 4 Kimmo Kinnunen 2022-02-16 23:16:53 PST 
Created attachment 452324 [details]
Patch for landing
Comment 5 EWS 2022-02-17 01:12:39 PST 
Committed r290004 (247390@main): <https://commits.webkit.org/247390@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 452324 [details].
Comment 6 Radar WebKit Bug Importer 2022-02-17 01:13:17 PST 
<rdar://problem/89074870>