Bug 236704

Summary: RemoteVideoFrameProxy should use RemoteVideoFrameObjectHeapProxy to get the pixel buffer representation
Product: WebKit Reporter: Kimmo Kinnunen <kkinnunen>
Component: New BugsAssignee: Kimmo Kinnunen <kkinnunen>
Status: RESOLVED FIXED    
Severity: Normal CC: eric.carlson, ews-watchlist, glenn, jer.noble, koivisto, philipj, sergio, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
ews-feeder: commit-queue-
Patch
none
Patch for landing none

Kimmo Kinnunen
Reported 2022-02-16 05:48:02 PST
RemoteVideoFrameProxy should use RemoteVideoFrameObjectHeapProxy to get the pixel buffer representation
Attachments
Patch (23.56 KB, patch)
2022-02-16 05:59 PST, Kimmo Kinnunen 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (24.19 KB, patch)
2022-02-16 06:11 PST, Kimmo Kinnunen 		no flags
DetailsFormatted DiffDiff
Patch for landing (24.20 KB, patch)
2022-02-16 23:16 PST, Kimmo Kinnunen 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Kimmo Kinnunen
Comment 1 2022-02-16 05:59:00 PST
Created attachment 452188 [details] Patch
Kimmo Kinnunen
Comment 2 2022-02-16 06:11:35 PST
Created attachment 452191 [details] Patch
Antti Koivisto
Comment 3 2022-02-16 07:23:48 PST
Comment on attachment 452191 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=452191&action=review > Source/WebKit/WebProcess/GPU/graphics/RemoteGraphicsContextGLProxy.cpp:181 > + return RemoteVideoFrameProxy::create(m_gpuProcessConnection->connection(), m_gpuProcessConnection->videoFrameObjectHeapProxy(), WTFMove(*result)); double space before WTFMove
Kimmo Kinnunen
Comment 4 2022-02-16 23:16:53 PST
Created attachment 452324 [details] Patch for landing
EWS
Comment 5 2022-02-17 01:12:39 PST
Committed r290004 (247390@main): <https://commits.webkit.org/247390@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 452324 [details].
Radar WebKit Bug Importer
Comment 6 2022-02-17 01:13:17 PST
<rdar://problem/89074870>
Note You need to log in before you can comment on or make changes to this bug.