Bug 236700

Summary:

[InputElement] Return empty string for an invalid floating-point number that ends with "."

Product:

WebKit

Reporter:

zsun

Component:

Forms

Assignee:

zsun

Status:

RESOLVED FIXED

Severity:

Normal

CC:

cdumez, changseok, darin, esprehn+autocc, ews-watchlist, gyuyoung.kim, webkit-bug-importer, wenson_hsieh

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none

Description zsun 2022-02-16 02:44:46 PST

https://html.spec.whatwg.org/multipage/input.html#number-state-(type%3Dnumber)

Comment 1 zsun 2022-02-16 02:51:00 PST

Created attachment 452166 [details]
Patch

Comment 2 zsun 2022-02-16 07:27:25 PST

Created attachment 452195 [details]
Patch

Comment 3 Chris Dumez 2022-02-16 09:30:23 PST

Comment on attachment 452195 [details]
Patch

r=me

Comment 4 EWS 2022-02-18 07:40:55 PST

Committed r290124 (247468@main): <https://commits.webkit.org/247468@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 452195 [details].

Comment 5 Radar WebKit Bug Importer 2022-02-18 07:41:27 PST

<rdar://problem/89144741>

Comment 6 Darin Adler 2022-02-18 08:58:15 PST

Comment on attachment 452195 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=452195&action=review

> Source/WebCore/html/parser/HTMLParserIdioms.cpp:134
> +    if (string.endsWith('.'))
> +        return fallbackValue;

Would be natural to have a comment here just like the one on the code paragraph above.