Bug 236668
| Summary: | Introduce postMessage mechanism for PDF.js viewer and use it for context menu items | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | pascoe <pascoe> |
| Component: | WebKit Misc. | Assignee: | Tim Nguyen (:ntim) <ntim> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | mcatanzaro, ntim, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=251887 | ||
| Bug Depends on: | |||
| Bug Blocks: | 235969 | ||
pascoe@apple.com
In https://bugs.webkit.org/show_bug.cgi?id=236525, it would be more efficient to directly get the PDFJSContentScript instead of using executeScriptIgnoringException.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/88985691>
Tim Nguyen (:ntim)
After discussing with Chris, it sounds like using postMessage here is the better option, for security reasons. When process isolation happens, the iframe and PDFDocument will be in different processes (since they are in different origins), so accessing functions from the iframe will not be safe.
Tim Nguyen (:ntim)
Pull request: https://github.com/WebKit/WebKit/pull/3083
EWS
Committed 253223@main (5b3fe7dc3092): <https://commits.webkit.org/253223@main>
Reviewed commits have been landed. Closing PR #3083 and removing active labels.