Bug 236663

Summary:

[WebKitLegacy] Fix clang tidy bugprone-move-forwarding-reference static analyzer warnings

Product:

WebKit

Reporter:

David Kilzer (:ddkilzer) <ddkilzer>

Component:

WebKit Misc.

Assignee:

David Kilzer (:ddkilzer) <ddkilzer>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

achristensen, darin, dino, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

Other

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch v1	none

David Kilzer (:ddkilzer)

Reported 2022-02-15 13:02:39 PST

Fix clang tidy bugprone-move-forwarding-reference static analyzer warnings in WebKitLegacy. Found by clang static analyzer. Only one issue remaining after WTF fixes in Source/WebKitLegacy/mac/Misc/WebDownload.mm.

Attachments
Patch v1 (1.45 KB, patch) 2022-02-15 13:52 PST, David Kilzer (:ddkilzer)	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2022-02-15 13:02:54 PST

<rdar://problem/88982792>

David Kilzer (:ddkilzer)

Comment 2 2022-02-15 13:52:24 PST

Created attachment 452088 [details] Patch v1

David Kilzer (:ddkilzer)

Comment 3 2022-02-16 07:36:11 PST

Comment on attachment 452088 [details] Patch v1 Adding cq+ since mac-wk1 tests passed.

EWS

Comment 4 2022-02-16 10:22:25 PST

Committed r289909 (247339@main): <https://commits.webkit.org/247339@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 452088 [details].

Note You need to log in before you can comment on or make changes to this bug.