Bug 236657 – [WebAuthn] Add credentialID to _WKWebAuthenticationAssertionResponse and userHandle in getAllLocalAuthenticatorCredentials

• Component: WebKit Misc.
• Status: RESOLVED FIXED

[[e-mail]]

These fields are needed for internal needs.

[Radar WebKit Bug Importer]

<rdar://problem/88979279>

[[e-mail]]

Created attachment 452103 [details]
Patch

[Brent Fulgham]

Comment on attachment 452103 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=452103&action=review

r=me

> Source/WebKit/UIProcess/API/Cocoa/_WKWebAuthenticationAssertionResponse.mm:73
> +    return wrapper(_response->credentialID());

Is it possible for _response to be nullptr?

[Brent Fulgham]

Comment on attachment 452103 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=452103&action=review

>> Source/WebKit/UIProcess/API/Cocoa/_WKWebAuthenticationAssertionResponse.mm:73
>> +    return wrapper(_response->credentialID());
> 
> Is it possible for _response to be nullptr?

Update: No, it's always dereferenced without checking.

[[e-mail]]

Comment on attachment 452103 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=452103&action=review

>> Source/WebKit/UIProcess/API/Cocoa/_WKWebAuthenticationAssertionResponse.mm:73
>> +    return wrapper(_response->credentialID());
> 
> Is it possible for _response to be nullptr?

I don't believe so, this is similar to userHandle. The only way we initialize _WKWebAuthenticationAssertionResponse is via APIWebAuthenticationAssertionResponse, which populates the _response.

[EWS]

Committed r290154 (247493@main): <https://commits.webkit.org/247493@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 452103 [details].