Bug 236652

Summary: Add a dedicated ENABLE flag for MediaRecorder
Product: WebKit Reporter: Philippe Normand <pnormand>
Component: WebCore Misc.Assignee: Philippe Normand <pnormand>
Status: RESOLVED FIXED    
Severity: Normal CC: annulen, benjamin, cdumez, cmarcelo, eric.carlson, esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, japhet, jer.noble, kangil.han, kondapallykalyan, philipj, ryuan.choi, sergio, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=236558
Attachments:
Description Flags
Patch
ews-feeder: commit-queue-
Patch
none
Patch
none
Patch none

Description Philippe Normand 2022-02-15 10:14:52 PST 
It should depend on MEDIA_STREAM and be enabled only for PLATFORM(COCOA) for now.
Comment 1 Philippe Normand 2022-02-15 10:17:27 PST 
Created attachment 452045 [details]
Patch
Comment 2 Philippe Normand 2022-02-15 10:22:11 PST 
EWS is not happy :)
Comment 3 Philippe Normand 2022-02-15 10:31:42 PST 
Created attachment 452047 [details]
Patch
Comment 4 Philippe Normand 2022-02-15 10:37:35 PST 
Comment on attachment 452047 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=452047&action=review

> Source/WebCore/Modules/mediarecorder/MediaRecorderProvider.cpp:42
> +#if PLATFORM(COCOA)

Should I add USE(AVFOUNDATION) here?
Comment 5 Eric Carlson 2022-02-15 16:46:59 PST 
Comment on attachment 452047 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=452047&action=review

r=me once the bots are happy

>> Source/WebCore/Modules/mediarecorder/MediaRecorderProvider.cpp:42
>> +#if PLATFORM(COCOA)
> 
> Should I add USE(AVFOUNDATION) here?

Good idea
Comment 6 Philippe Normand 2022-02-16 01:41:54 PST 
Created attachment 452160 [details]
Patch
Comment 7 Philippe Normand 2022-02-16 03:31:31 PST 
Created attachment 452173 [details]
Patch
Comment 8 EWS 2022-02-16 09:20:31 PST 
Committed r289894 (247331@main): <https://commits.webkit.org/247331@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 452173 [details].
Comment 9 Radar WebKit Bug Importer 2022-02-16 09:21:20 PST 
<rdar://problem/89029790>