Bug 236651

Summary: Share WebKitTestRunner code among USE(LIBWPE) ports
Product: WebKit Reporter: Don Olmstead <don.olmstead>
Component: Tools / TestsAssignee: Don Olmstead <don.olmstead>
Status: RESOLVED FIXED    
Severity: Normal CC: annulen, aperez, ews-watchlist, gyuyoung.kim, ryuan.choi, sergio, webkit-bug-importer, zdobersek
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
ews-feeder: commit-queue-
Patch
ews-feeder: commit-queue-
Patch
none
Patch none

Don Olmstead
Reported 2022-02-15 10:11:06 PST
The PlatformWebView and EventSenderProxy implementations just use libwpe directly.
Attachments
Patch (8.81 KB, patch)
2022-02-15 10:47 PST, Don Olmstead 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (10.72 KB, patch)
2022-02-15 10:50 PST, Don Olmstead 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (10.72 KB, patch)
2022-02-15 11:13 PST, Don Olmstead 		no flags
DetailsFormatted DiffDiff
Patch (10.72 KB, patch)
2022-02-15 11:18 PST, Don Olmstead 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Don Olmstead
Comment 1 2022-02-15 10:47:30 PST Comment hidden (obsolete)
Don Olmstead
Comment 2 2022-02-15 10:50:52 PST Comment hidden (obsolete)
Don Olmstead
Comment 3 2022-02-15 11:13:39 PST Comment hidden (obsolete)
Don Olmstead
Comment 4 2022-02-15 11:18:07 PST
Created attachment 452061 [details] Patch
Don Olmstead
Comment 5 2022-02-15 13:49:12 PST
AppleWin doesn't use WebKitTestRunner so the failure is unrelated to this change.
Zan Dobersek (Reviews)
Comment 6 2022-02-15 22:47:04 PST
Comment on attachment 452061 [details] Patch LGTM.
EWS
Comment 7 2022-02-16 05:54:22 PST
Committed r289887 (247325@main): <https://commits.webkit.org/247325@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 452061 [details].
Radar WebKit Bug Importer
Comment 8 2022-02-16 05:55:17 PST
<rdar://problem/89021314>
Note You need to log in before you can comment on or make changes to this bug.