Bug 236643

Summary: [JSC] Guard against dead remotes in numberOfProcessors
Product: WebKit Reporter: Angelos Oikonomopoulos <angelos>
Component: New BugsAssignee: Angelos Oikonomopoulos <angelos>
Status: RESOLVED FIXED    
Severity: Normal CC: aperez, Hironori.Fujii, jbedard, mcatanzaro, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Angelos Oikonomopoulos
Reported 2022-02-15 06:09:31 PST
[JSC] Guard against dead remotes in numberOfProcessors
Attachments
Patch (2.43 KB, patch)
2022-02-15 06:11 PST, Angelos Oikonomopoulos 		no flags
DetailsFormatted DiffDiff
Patch (2.76 KB, patch)
2022-02-21 01:49 PST, Angelos Oikonomopoulos 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Angelos Oikonomopoulos
Comment 1 2022-02-15 06:11:13 PST
Created attachment 452014 [details] Patch
Angelos Oikonomopoulos
Comment 2 2022-02-21 01:49:09 PST
Created attachment 452720 [details] Patch
Adrian Perez
Comment 3 2022-02-22 01:47:34 PST
Comment on attachment 452720 [details] Patch r=me View in context: https://bugs.webkit.org/attachment.cgi?id=452720&action=review > Tools/Scripts/run-jsc-stress-tests:2585 > + numProcessors = runCommandOnTester("sysctl -n hw.activecpu 2>/dev/null || nproc --all 2>/dev/null").to_i I wonder if it would be better/good to use “getconf _NPROCESSORS_ONLN“ or have it as yet another fallback 🤔️ Anyway, just a thought, no need to update the patch for it.
Angelos Oikonomopoulos
Comment 4 2022-02-22 01:52:49 PST
(In reply to Adrian Perez from comment #3) > Comment on attachment 452720 [details] > Patch > > r=me > > View in context: > https://bugs.webkit.org/attachment.cgi?id=452720&action=review > > > Tools/Scripts/run-jsc-stress-tests:2585 > > + numProcessors = runCommandOnTester("sysctl -n hw.activecpu 2>/dev/null || nproc --all 2>/dev/null").to_i > > I wonder if it would be better/good to use “getconf _NPROCESSORS_ONLN“ or > have > it as yet another fallback 🤔️ That's probably a good idea. And since you mention _NPROCESSORS_ONLN, it'd probably make sense to remove the --all argument from the nproc invocation too.
EWS
Comment 5 2022-02-22 02:26:53 PST
Committed r290298 (247621@main): <https://commits.webkit.org/247621@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 452720 [details].
Radar WebKit Bug Importer
Comment 6 2022-02-22 02:27:16 PST
<rdar://problem/89283653>
Note You need to log in before you can comment on or make changes to this bug.