| Summary: | [JSC] Guard against dead remotes in numberOfProcessors | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Angelos Oikonomopoulos <angelos> | ||||||
| Component: | New Bugs | Assignee: | Angelos Oikonomopoulos <angelos> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | aperez, Hironori.Fujii, jbedard, mcatanzaro, webkit-bug-importer, ysuzuki | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Angelos Oikonomopoulos
2022-02-15 06:09:31 PST
Created attachment 452014 [details]
Patch
Created attachment 452720 [details]
Patch
Comment on attachment 452720 [details] Patch r=me View in context: https://bugs.webkit.org/attachment.cgi?id=452720&action=review > Tools/Scripts/run-jsc-stress-tests:2585 > + numProcessors = runCommandOnTester("sysctl -n hw.activecpu 2>/dev/null || nproc --all 2>/dev/null").to_i I wonder if it would be better/good to use “getconf _NPROCESSORS_ONLN“ or have it as yet another fallback 🤔️ Anyway, just a thought, no need to update the patch for it. (In reply to Adrian Perez from comment #3) > Comment on attachment 452720 [details] > Patch > > r=me > > View in context: > https://bugs.webkit.org/attachment.cgi?id=452720&action=review > > > Tools/Scripts/run-jsc-stress-tests:2585 > > + numProcessors = runCommandOnTester("sysctl -n hw.activecpu 2>/dev/null || nproc --all 2>/dev/null").to_i > > I wonder if it would be better/good to use “getconf _NPROCESSORS_ONLN“ or > have > it as yet another fallback 🤔️ That's probably a good idea. And since you mention _NPROCESSORS_ONLN, it'd probably make sense to remove the --all argument from the nproc invocation too. Committed r290298 (247621@main): <https://commits.webkit.org/247621@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 452720 [details]. |