| Summary: | [GTK] Let run-gtk-tests execute test by name | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Diego Pino <dpino> | ||||||||||
| Component: | New Bugs | Assignee: | Diego Pino <dpino> | ||||||||||
| Status: | RESOLVED FIXED | ||||||||||||
| Severity: | Normal | CC: | bugs-noreply, cgarcia, webkit-bug-importer | ||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||
| Version: | WebKit Nightly Build | ||||||||||||
| Hardware: | Unspecified | ||||||||||||
| OS: | Unspecified | ||||||||||||
| Attachments: |
|
||||||||||||
|
Description
Diego Pino
2022-02-14 17:09:31 PST
Created attachment 451966 [details]
Patch
In branch 'main': ./Tools/Scripts/run-gtk-tests --release WebKitBuild/GTK/Release/bin/TestWebKitAPI/TestWebCore -p Color.Equality: SUCCESS ./Tools/Scripts/run-gtk-tests --release GTK/Release/bin/TestWebKitAPI/TestWebCore -p Color.Equality: ERROR ./Tools/Scripts/run-gtk-tests --release TestWebCore -p Color.Equality: ERROR Patch applied: ./Tools/Scripts/run-gtk-tests --release WebKitBuild/GTK/Release/bin/TestWebKitAPI/TestWebCore -p Color.Equality: SUCCESS ./Tools/Scripts/run-gtk-tests --release GTK/Release/bin/TestWebKitAPI/TestWebCore -p Color.Equality: ERROR ./Tools/Scripts/run-gtk-tests --release TestWebCore -p Color.Equality: SUCCESS Created attachment 451996 [details]
Patch
Comment on attachment 451996 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=451996&action=review > Tools/glib/common.py:161 > + return os.path.join(root_path, "WebKitBuild/{}/{}/bin/TestWebKitAPI".format(platform.upper(), configuration)) I like the idea but this only works when using flatpak. You should use build_path() to get the path to the build directory Created attachment 452126 [details]
Patch
Comment on attachment 452126 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=452126&action=review > Tools/glib/api_test_runner.py:93 > + if not os.path.exists(test): > + candidate = os.path.join(self._test_programs_base_dir(), test) > + if os.path.exists(candidate): > + test = candidate Much simpler! We should probably show an error message if candidate doesn't exit either, no? Created attachment 452181 [details]
Patch
Committed r289982 (247368@main): <https://commits.webkit.org/247368@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 452181 [details]. |