Bug 236623

Summary: [GTK] Let run-gtk-tests execute test by name
Product: WebKit Reporter: Diego Pino <dpino>
Component: New BugsAssignee: Diego Pino <dpino>
Status: RESOLVED FIXED    
Severity: Normal CC: bugs-noreply, cgarcia, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch none

Diego Pino
Reported 2022-02-14 17:09:31 PST
[GTK] Let run-gtk-tests execute test by name
Attachments
Patch (2.45 KB, patch)
2022-02-14 17:22 PST, Diego Pino 		no flags
DetailsFormatted DiffDiff
Patch (3.87 KB, patch)
2022-02-14 22:32 PST, Diego Pino 		no flags
DetailsFormatted DiffDiff
Patch (1.42 KB, patch)
2022-02-15 20:02 PST, Diego Pino 		no flags
DetailsFormatted DiffDiff
Patch (1.52 KB, patch)
2022-02-16 04:24 PST, Diego Pino 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Diego Pino
Comment 1 2022-02-14 17:22:53 PST
Created attachment 451966 [details] Patch
Diego Pino
Comment 2 2022-02-14 17:25:32 PST
In branch 'main': ./Tools/Scripts/run-gtk-tests --release WebKitBuild/GTK/Release/bin/TestWebKitAPI/TestWebCore -p Color.Equality: SUCCESS ./Tools/Scripts/run-gtk-tests --release GTK/Release/bin/TestWebKitAPI/TestWebCore -p Color.Equality: ERROR ./Tools/Scripts/run-gtk-tests --release TestWebCore -p Color.Equality: ERROR Patch applied: ./Tools/Scripts/run-gtk-tests --release WebKitBuild/GTK/Release/bin/TestWebKitAPI/TestWebCore -p Color.Equality: SUCCESS ./Tools/Scripts/run-gtk-tests --release GTK/Release/bin/TestWebKitAPI/TestWebCore -p Color.Equality: ERROR ./Tools/Scripts/run-gtk-tests --release TestWebCore -p Color.Equality: SUCCESS
Diego Pino
Comment 3 2022-02-14 22:32:19 PST
Created attachment 451996 [details] Patch
Carlos Garcia Campos
Comment 4 2022-02-15 00:29:50 PST
Comment on attachment 451996 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=451996&action=review > Tools/glib/common.py:161 > + return os.path.join(root_path, "WebKitBuild/{}/{}/bin/TestWebKitAPI".format(platform.upper(), configuration)) I like the idea but this only works when using flatpak. You should use build_path() to get the path to the build directory
Diego Pino
Comment 5 2022-02-15 20:02:40 PST
Created attachment 452126 [details] Patch
Carlos Garcia Campos
Comment 6 2022-02-16 00:40:39 PST
Comment on attachment 452126 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=452126&action=review > Tools/glib/api_test_runner.py:93 > + if not os.path.exists(test): > + candidate = os.path.join(self._test_programs_base_dir(), test) > + if os.path.exists(candidate): > + test = candidate Much simpler! We should probably show an error message if candidate doesn't exit either, no?
Diego Pino
Comment 7 2022-02-16 04:24:39 PST
Created attachment 452181 [details] Patch
EWS
Comment 8 2022-02-16 16:41:48 PST
Committed r289982 (247368@main): <https://commits.webkit.org/247368@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 452181 [details].
Radar WebKit Bug Importer
Comment 9 2022-02-16 16:42:17 PST
<rdar://problem/89056142>
Note You need to log in before you can comment on or make changes to this bug.