| Summary: | testapi should handle a missing testapiScripts directory cleaner | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Keith Miller <keith_miller> | ||||
| Component: | New Bugs | Assignee: | Keith Miller <keith_miller> | ||||
| Status: | NEW --- | ||||||
| Severity: | Normal | CC: | ews-watchlist, mark.lam, msaboff, saam, tzagallo, webkit-bug-importer, ysuzuki | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Keith Miller
2022-02-14 09:20:43 PST
Created attachment 451912 [details]
Patch
Comment on attachment 451912 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=451912&action=review r=me > Source/JavaScriptCore/API/tests/testapi.mm:2839 > + if (![resolvePathToScripts() checkResourceIsReachableAndReturnError:nil]) { > + NSLog(@"File URL to testapiScripts: %@", resolvePathToScripts()); > + checkResult(@"File URL to `testapiScripts` isn't reachable is the directory in place?", false); > + return; > + } > + How about always showing NSLog(@"File URL to testapiScripts: %@", resolvePathToScripts()); and doing, checkResult(@"File URL to `testapiScripts` isn't reachable is the directory in place?", [resolvePathToScripts() checkResourceIsReachableAndReturnError:nil]); Comment on attachment 451912 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=451912&action=review >> Source/JavaScriptCore/API/tests/testapi.mm:2839 >> + > > How about always showing > > NSLog(@"File URL to testapiScripts: %@", resolvePathToScripts()); > > and doing, > > checkResult(@"File URL to `testapiScripts` isn't reachable is the directory in place?", [resolvePathToScripts() checkResourceIsReachableAndReturnError:nil]); Ok, sounds good. Comment on attachment 451912 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=451912&action=review >>> Source/JavaScriptCore/API/tests/testapi.mm:2839 >>> + >> >> How about always showing >> >> NSLog(@"File URL to testapiScripts: %@", resolvePathToScripts()); >> >> and doing, >> >> checkResult(@"File URL to `testapiScripts` isn't reachable is the directory in place?", [resolvePathToScripts() checkResourceIsReachableAndReturnError:nil]); > > Ok, sounds good. Do you think we should return after finding the file is missing or just continue in case the test doesn't rely on that directory? |