PopupMenuChromium.h could be cleaned-up

• Component: WebCore Misc.
• Status: RESOLVED FIXED

[Jay Campan]

In WebCore/platform/chromium/PopupMenuChromium.h many states are passed around with setters (setTextOnIndexChange, setAcceptOnAbandon, setLoopSelectionNavigation...). As these settings are only required when initializing and as new ones may be added, it would be better to have a settings struct instead of setters.

[Jay Campan]

Created attachment 27190 [details]
Patch for PopuMenuChromium.[h,cpp]

[Eric Seidel (no email)]

Comment on attachment 27190 [details]
Patch for PopuMenuChromium.[h,cpp]

This looks fine.

 1 2009-01-29  Jay Campan  <set EMAIL_ADDRESS environment variable>

Your EMAIL_ADDRESS is missing.

Wrong spacing:
+static const PopupContainerSettings dropDownSettings = {
+  true, // focusOnShow
+  true, // setTextOnIndexChange
+  true, // acceptOnAbandon
+  false // loopSelectionNavigation
+};

This looks fine.  Can be fixed on commit.

[Eric Seidel (no email)]

Grats on your first patch to the webkit.org tree Jay. :)

[Eric Seidel (no email)]

Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	WebCore/ChangeLog
	M	WebCore/platform/chromium/PopupMenuChromium.cpp
	M	WebCore/platform/chromium/PopupMenuChromium.h
Committed r40494