Bug 236505

Summary: WebGL GPUP OpenGL context is not used even if WebGL via Metal is deselected
Product: WebKit Reporter: Kimmo Kinnunen <kkinnunen>
Component: WebGLAssignee: Kimmo Kinnunen <kkinnunen>
Status: RESOLVED FIXED    
Severity: Normal CC: dino, ews-watchlist, jonlee, kbr, kkinnunen, kondapallykalyan, mmaxfield, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=236382
Bug Depends on:    
Bug Blocks: 217211    
Attachments:
Description Flags
wip
none
Patch
none
Patch
none
Patch
none
Patch none

Description Kimmo Kinnunen 2022-02-11 07:13:07 PST 
WebGL GPUP OpenGL context is not used even if WebGL via Metal is deselected

when useMetal attribute was added, it wasn't added to the serialisation
Comment 1 Radar WebKit Bug Importer 2022-02-12 19:47:23 PST 
<rdar://problem/88862936>
Comment 2 Kimmo Kinnunen 2022-02-13 11:22:37 PST 
Created attachment 451828 [details]
wip
Comment 3 Kimmo Kinnunen 2022-02-14 07:23:51 PST 
Created attachment 451900 [details]
Patch
Comment 4 Kimmo Kinnunen 2022-02-28 04:00:03 PST 
Created attachment 453380 [details]
Patch
Comment 5 Kimmo Kinnunen 2022-02-28 05:35:43 PST 
Created attachment 453385 [details]
Patch
Comment 6 Kimmo Kinnunen 2022-02-28 10:43:17 PST 
Created attachment 453408 [details]
Patch
Comment 7 Myles C. Maxfield 2022-02-28 10:48:15 PST 
Comment on attachment 453408 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=453408&action=review

> Source/WebCore/platform/graphics/GraphicsContextGLAttributes.h:80
> +#if ENABLE(GPU_PROCESS)

Is there harm in leaving these functions in, even if !ENABLE(GPU_PROCESS)? I generally view #ifs as worse than leaving in unused functions.
Comment 8 Kimmo Kinnunen 2022-03-01 05:41:00 PST 
> Is there harm in leaving these functions in, even if !ENABLE(GPU_PROCESS)? I generally view #ifs as worse than leaving in unused functions.

I think it's the project style to use the ifdefs?
The old code also had the ifdefs, as has other similar code.

I'd like if the project moved to style with less ifdefs.
Comment 9 EWS 2022-03-01 06:33:26 PST 
Committed r290643 (247916@main): <https://commits.webkit.org/247916@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 453408 [details].