Bug 236504

Summary:

Git commit message hook should allow source = 'template' case

Product:

WebKit

Reporter:

Jonathan Bedard <jbedard>

Component:

Tools / Tests

Assignee:

Jonathan Bedard <jbedard>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aakash_jain, ap, dewei_zhu, eddy_wong, ryanhaddad, slewis, thorton, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none

Description Jonathan Bedard 2022-02-11 07:06:47 PST

Certain Git tools change what source is in our hook, we should support those tools.

Comment 1 Jonathan Bedard 2022-02-11 07:07:13 PST

<rdar://problem/88787806>

Comment 2 Jonathan Bedard 2022-02-11 07:08:23 PST

Created attachment 451689 [details]
Patch

Comment 3 eddy_wong 2022-02-11 10:43:24 PST

Comment on attachment 451689 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=451689&action=review

> Tools/Scripts/hooks/prepare-commit-msg:45
> +    if source not in ('commit', 'template'):

source could be None too

Comment 4 Jonathan Bedard 2022-02-11 10:44:54 PST

(In reply to eddy_wong from comment #3)
> Comment on attachment 451689 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=451689&action=review
> 
> > Tools/Scripts/hooks/prepare-commit-msg:45
> > +    if source not in ('commit', 'template'):
> 
> source could be None too

Oops, good point, messed that one up....

(as a side note, the case that doesn't fall into any of these categories is the rebase one)

Comment 5 Jonathan Bedard 2022-02-11 10:47:27 PST

Created attachment 451725 [details]
Patch

Comment 6 EWS 2022-02-11 12:08:56 PST

Committed r289656 (247149@main): <https://commits.webkit.org/247149@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 451725 [details].