Bug 236487 – WebGL context should use discrete gpu if the context is created when the window is on external monitor, ANGLE Metal backend

• Component: WebGL
• Status: RESOLVED FIXED

[Kimmo Kinnunen]

WebGL context should use discrete gpu if the context is created when the window is on external monitor

[Radar WebKit Bug Importer]

<rdar://problem/89131272>

[Kimmo Kinnunen]

Created attachment 453837 [details]
WIP for monday

[Kimmo Kinnunen]

Created attachment 454109 [details]
Patch

[Kenneth Russell]

Adding Kyle and ANGLE folks as FYI.

[Kenneth Russell]

Comment on attachment 454109 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=454109&action=review

Looks great. A couple of small comments, but r+.

> Source/WebCore/platform/graphics/cocoa/GraphicsContextGLCocoa.mm:161
> +            // is anyway already powered on.

Perhaps mention here that this code relies on the assumption that EGL_ANGLE_platform_angle_device_id uses the IOKit registry ID of the GPU on Mac platforms?

> Source/WebCore/platform/graphics/cocoa/GraphicsContextGLCocoa.mm:163
> +                displayAttributes.append(EGL_PLATFORM_ANGLE_DEVICE_ID_HIGH_ANGLE);

Would you like to at least ASSERT the availability of the EGL_ANGLE_platform_angle_device_id EGL client extension somewhere?

[Kimmo Kinnunen]

Created attachment 454207 [details]
Patch for landing

[EWS]

Committed r291224 (248379@main): <https://commits.webkit.org/248379@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 454207 [details].