| Summary: | [WebAuthn] Access group not set in add query for importLocalAuthenticatorCredential | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | pascoe <pascoe> | ||||||
| Component: | WebKit Misc. | Assignee: | pascoe <pascoe> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | bfulgham, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
pascoe@apple.com
2022-02-10 15:59:15 PST
Created attachment 451702 [details]
Patch
Comment on attachment 451702 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=451702&action=review r=me > Source/WebKit/ChangeLog:9 > + In the patch adding support for setting accessGroup, previously did not properly set Suggestion: In Bug 236311 we added support setting accessGroup, but did not properly set it on the addQuery. This patch fixes that. > Tools/ChangeLog:14 > + * TestWebKitAPI/Tests/WebKitCocoa/_WKWebAuthenticationPanel.mm: Really nice that you managed to create a test to protect this behavior! Created attachment 451905 [details]
Patch for landing
Committed r289760 (247232@main): <https://commits.webkit.org/247232@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 451905 [details]. |