Web Inspector: click to re-enable breakpoint clears automatic continue

• Component: Web Inspector
• Status: RESOLVED FIXED

[Jeff Johnson]

Steps to reproduce:
1. Create new breakpoint
2. Add Action
3. Enter some JavaScript to evaluate
3. Select "Automatically continue after evaluating"
4. Close popup
5. Click the new breakpoint to disable
6. Click the new breakpoint again to enable

Expected results:
Automatically continue after evaluating is enabled.

Actual results:
Automatically continue after evaluating is disabled.

This behavior is very problematic when I need to repeatedly disable and re-enable a breakpoint.

[Patrick Angle]

Currently clicking on a breakpoint with actions will cycle through `Enabled without continue` -> `Enabled /w continue` -> `Disabled` in an effort to make it easier to switch between the first two states in cases where you may only want to pause sometimes, but always want the actions to be run. This was implemented in r161687.

[Jeff Johnson]

(In reply to Patrick Angle from comment #1)
> Currently clicking on a breakpoint with actions will cycle through `Enabled
> without continue` -> `Enabled /w continue` -> `Disabled` in an effort to
> make it easier to switch between the first two states in cases where you may
> only want to pause sometimes, but always want the actions to be run. This
> was implemented in r161687.

This 3-way toggle doesn't seem very discoverable, especially since all other breakpoints are click on, click off.

Might I suggest a little separate widget to the left of breakpoints that have an action, and thus have the Automatically continue option? Then the breakpoint and Automatically continue can be separately toggled easily.

[Jeff Johnson]

Just looking at Xcode for comparison. Xcode does not have a 3-way toggle. However, Xcode does open the breakpoint popup for editing on double-click, whereas the web inspector does not. Thus, it may be a good alternative for the web inspector to edit the breakpoint on double-click.

[Devin Rousso]

Created attachment 451736 [details]
[fast-cq] Patch

[Patrick Angle]

Comment on attachment 451736 [details]
[fast-cq] Patch

r=me

[EWS]

Committed r289669 (247157@main): <https://commits.webkit.org/247157@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 451736 [details].

[Radar WebKit Bug Importer]

<rdar://problem/88833824>