Bug 236460

Summary: tryReserveUncommittedAligned should explicitly take the alignment requested
Product: WebKit Reporter: Keith Miller <keith_miller>
Component: New BugsAssignee: Keith Miller <keith_miller>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, cdumez, cmarcelo, ews-watchlist, mark.lam, msaboff, saam, tzagallo, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing
none
Patch for landing none

Description Keith Miller 2022-02-10 12:49:15 PST
tryReserveUncommittedAligned should explicitly take the alignment requested
Comment 1 Keith Miller 2022-02-10 13:00:06 PST
Created attachment 451591 [details]
Patch
Comment 2 Yusuke Suzuki 2022-02-10 13:33:47 PST
Comment on attachment 451591 [details]
Patch

r=me
Comment 3 Keith Miller 2022-02-10 13:34:58 PST
Comment on attachment 451591 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=451591&action=review

> Source/JavaScriptCore/ChangeLog:11
> +        original alignment to the allocator as a new parameter.

Forgot to comment that I added another branch of code for Unix flavors that have the `MAP_ALIGNED` flag. Will add that before landing.
Comment 4 Keith Miller 2022-02-10 13:47:46 PST
Created attachment 451597 [details]
Patch for landing
Comment 5 Keith Miller 2022-02-10 13:48:14 PST
Created attachment 451598 [details]
Patch for landing
Comment 6 EWS 2022-02-10 16:21:37 PST
Committed r289592 (247105@main): <https://commits.webkit.org/247105@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 451598 [details].
Comment 7 Radar WebKit Bug Importer 2022-02-10 16:22:16 PST
<rdar://problem/88784711>