Bug 236460

Summary: tryReserveUncommittedAligned should explicitly take the alignment requested
Product: WebKit Reporter: Keith Miller <keith_miller>
Component: New BugsAssignee: Keith Miller <keith_miller>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, cdumez, cmarcelo, ews-watchlist, mark.lam, msaboff, saam, tzagallo, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing
none
Patch for landing none

Keith Miller
Reported 2022-02-10 12:49:15 PST
tryReserveUncommittedAligned should explicitly take the alignment requested
Attachments
Patch (9.87 KB, patch)
2022-02-10 13:00 PST, Keith Miller 		no flags
DetailsFormatted DiffDiff
Patch for landing (9.99 KB, patch)
2022-02-10 13:47 PST, Keith Miller 		no flags
DetailsFormatted DiffDiff
Patch for landing (9.99 KB, patch)
2022-02-10 13:48 PST, Keith Miller 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Keith Miller
Comment 1 2022-02-10 13:00:06 PST
Created attachment 451591 [details] Patch
Yusuke Suzuki
Comment 2 2022-02-10 13:33:47 PST
Comment on attachment 451591 [details] Patch r=me
Keith Miller
Comment 3 2022-02-10 13:34:58 PST
Comment on attachment 451591 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=451591&action=review > Source/JavaScriptCore/ChangeLog:11 > + original alignment to the allocator as a new parameter. Forgot to comment that I added another branch of code for Unix flavors that have the `MAP_ALIGNED` flag. Will add that before landing.
Keith Miller
Comment 4 2022-02-10 13:47:46 PST
Created attachment 451597 [details] Patch for landing
Keith Miller
Comment 5 2022-02-10 13:48:14 PST
Created attachment 451598 [details] Patch for landing
EWS
Comment 6 2022-02-10 16:21:37 PST
Committed r289592 (247105@main): <https://commits.webkit.org/247105@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 451598 [details].
Radar WebKit Bug Importer
Comment 7 2022-02-10 16:22:16 PST
<rdar://problem/88784711>
Note You need to log in before you can comment on or make changes to this bug.