Bug 236430

Summary: REGRESSION(r288412): [WPE] Several WPT SVG import filter tests are now failing
Product: WebKit Reporter: Diego Pino <dpino>
Component: SVGAssignee: Nobody <webkit-unassigned>
Status: NEW ---    
Severity: Normal CC: bugs-noreply, sabouhallawa, webkit-bug-importer, zimmermann
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Comparison of baselines for test GTK vs WPE none

Description Diego Pino 2022-02-09 23:38:41 PST 
Created attachment 451498 [details]
Comparison of baselines for test GTK vs WPE

The following tests started failing after r288412:

  imported/w3c/web-platform-tests/svg/import/filters-composite-04-f-manual.svg
  imported/w3c/web-platform-tests/svg/import/filters-composite-05-f-manual.svg
  imported/w3c/web-platform-tests/svg/import/filters-conv-03-f-manual.svg
  imported/w3c/web-platform-tests/svg/import/filters-displace-01-f-manual.svg
  imported/w3c/web-platform-tests/svg/import/filters-image-01-b-manual.svg
  imported/w3c/web-platform-tests/svg/import/filters-image-02-b-manual.svg
  imported/w3c/web-platform-tests/svg/import/filters-image-03-f-manual.svg
  imported/w3c/web-platform-tests/svg/import/filters-image-04-f-manual.svg
  imported/w3c/web-platform-tests/svg/import/filters-image-05-f-manual.svg

For instance:

https://results.webkit.org/?suite=layout-tests&test=imported%2Fw3c%2Fweb-platform-tests%2Fsvg%2Fimport%2Ffilters-composite-04-f-manual.svg&platform=GTK&platform=WPE

r289510 updated the WPE baselines, but this is not the right fix. The tests are passing in WebKitGTK. Output should be the same (see attached screenhot).
Comment 1 Radar WebKit Bug Importer 2024-01-16 13:46:53 PST 
<rdar://problem/121074938>
Comment 2 Said Abou-Hallawa 2024-01-17 13:23:32 PST 
These tests are referencing non existent resource images. Here are some examples from these tests.

<feImage xlink:href="../images/stefan_252_tRNS_opti.png" result="bird"/>

<image width="120" height="80" xlink:href="../images/tree.jpg" filter="url(#dissolve1)" transform="translate(100 80)"/>

<image id="img" xlink:href="../images/purplesquidj.png" x="80" y="100" width="100" height="100"/>


<feImage result="Texture" xlink:href="../images/DisplaceChecker.png"/>


<feImage result="Map" xlink:href="../images/sphere.png"/>

<feImage x="145" y="50" width="190" height="190" xlink:href="../images/image1.jpg"/>

<feImage xlink:href="../images/bluesquidj.png">
    <set attributeName="xlink:href" to="../images/pinksquidj.png" begin="2s"/>
</feImage>


<feImage height="27.6%" xlink:href="../images/smiley.png"/>

Running them on macOS will timeout. 

Also these tests do not exist in https://wpt.fyi/results/svg. So I am not sure what the right approach to fix these failures should be. I think we should remove all the import directory since some of its tests are not working correctly for two years now.
Comment 3 Said Abou-Hallawa 2024-01-17 14:43:47 PST 
All these tests are for manual testing and that is why they all have dump render tree expected results. I think we need to move this directory out form the WPT directory and make them ref tests as much as we can.