Bug 236423

Summary: Exclude new LocalStorage directory from backup on iOS
Product: WebKit Reporter: Sihui Liu <sihui_liu>
Component: Website StorageAssignee: Sihui Liu <sihui_liu>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, darin, sihui_liu, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing none

Sihui Liu
Reported 2022-02-09 18:21:08 PST
...
Attachments
Patch (2.66 KB, patch)
2022-02-16 21:15 PST, Sihui Liu 		no flags
DetailsFormatted DiffDiff
Patch for landing (2.64 KB, patch)
2022-02-17 22:33 PST, Sihui Liu 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2022-02-16 18:22:16 PST
<rdar://problem/89060863>
Sihui Liu
Comment 2 2022-02-16 21:15:15 PST
Created attachment 452308 [details] Patch
Darin Adler
Comment 3 2022-02-17 01:10:22 PST
Comment on attachment 452308 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=452308&action=review > Source/WebKit/ChangeLog:10 > + We've been excluding LocalStorage data from backup on iOS since r212555, and we need to make sure this applies > + to new LocalStorage directory after migration (r289878). What about on devices where the old code ran, the directory was created, but excludeFromBackup was not called? Are those devices permanently in an incorrect state? What will heal them?
Sihui Liu
Comment 4 2022-02-17 10:49:17 PST
Comment on attachment 452308 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=452308&action=review >> Source/WebKit/ChangeLog:10 >> + to new LocalStorage directory after migration (r289878). > > What about on devices where the old code ran, the directory was created, but excludeFromBackup was not called? Are those devices permanently in an incorrect state? What will heal them? The new LocalStorage directory is not in use yet: r289878 only adds code for migration. So this code is added before the directory is created. I am trying to make sure everything works correctly before we start to use the new directory.
Darin Adler
Comment 5 2022-02-17 11:25:49 PST
Comment on attachment 452308 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=452308&action=review >>> Source/WebKit/ChangeLog:10 >>> + to new LocalStorage directory after migration (r289878). >> >> What about on devices where the old code ran, the directory was created, but excludeFromBackup was not called? Are those devices permanently in an incorrect state? What will heal them? > > The new LocalStorage directory is not in use yet: r289878 only adds code for migration. So this code is added before the directory is created. I am trying to make sure everything works correctly before we start to use the new directory. Sounds good
Sihui Liu
Comment 6 2022-02-17 22:33:06 PST
Created attachment 452483 [details] Patch for landing
EWS
Comment 7 2022-02-17 23:47:14 PST
Committed r290115 (247459@main): <https://commits.webkit.org/247459@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 452483 [details].
Note You need to log in before you can comment on or make changes to this bug.