Bug 236414

Summary:

AXIsolatedTree::updateChildren and AXIsolatedTree::nodeAncestryChanges results in adding incorrect nodes to the isolated tree

Product:

WebKit

Reporter:

Tyler Wilcock <tyler_w>

Component:

Accessibility

Assignee:

Tyler Wilcock <tyler_w>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aboxhall, andresg_22, apinheiro, cfleizach, dmazzoni, ews-watchlist, jcraig, jdiggs, samuel_white, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none
Patch	ews-feeder: commit-queue-
Patch	none

Tyler Wilcock

Reported 2022-02-09 16:26:30 PST

Sometimes AXIsolatedTree::updateChildren is called with an object that is not in the isolated tree. When this happens, we currently call AXIsolatedTree::nodeAncestryChanges to build the ancestry chain up to the nearest in-isolated-tree node (starting with the original object called for updateChildren). However, this seems to result in adding nodes to the isolated tree that don't exist in the live tree. I believe this also causes isolated objects to often hold references to parent objects that don't exist in the isolated tree, breaking searches (and more).

Attachments
Patch (9.42 KB, patch) 2022-02-09 16:52 PST, Tyler Wilcock	no flags	Details Formatted Diff Diff
Patch (9.42 KB, patch) 2022-02-09 16:54 PST, Tyler Wilcock	no flags	Details Formatted Diff Diff
Patch (10.77 KB, patch) 2022-02-09 17:54 PST, Tyler Wilcock	no flags	Details Formatted Diff Diff
Patch (10.99 KB, patch) 2022-02-09 17:58 PST, Tyler Wilcock	ews-feeder: commit-queue-	Details Formatted Diff Diff
Patch (10.99 KB, patch) 2022-02-09 18:30 PST, Tyler Wilcock	no flags	Details Formatted Diff Diff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.