Bug 236407

Summary: [TextureMapperGL] drop-shadow filter with blur-radius doesn't work as expected if it is the last filter
Product: WebKit Reporter: Fujii Hironori <Hironori.Fujii>
Component: PlatformAssignee: Fujii Hironori <Hironori.Fujii>
Status: RESOLVED FIXED    
Severity: Normal CC: clord, cmarcelo, don.olmstead, ews-watchlist, kondapallykalyan, luiz, magomez, ujwal.koneru, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
test case
none
WIP patch
none
WIP patch
none
drop-shadow filter and opacity
none
WIP patch
none
Patch
none
Patch none

Fujii Hironori
Reported 2022-02-09 14:02:36 PST
Created attachment 451441 [details] test case [TextureMapperGL] drop-shadow filter with blur-radius should expand the intermediate surface to render css3/filters/effect-drop-shadow-hw.html is a test case.
Attachments
test case (1.17 KB, text/html)
2022-02-09 14:02 PST, Fujii Hironori 		no flags
Details
WIP patch (2.01 KB, patch)
2022-02-09 17:22 PST, Fujii Hironori 		no flags
DetailsFormatted DiffDiff
WIP patch (1.14 KB, patch)
2022-02-09 18:39 PST, Fujii Hironori 		no flags
DetailsFormatted DiffDiff
drop-shadow filter and opacity (963 bytes, text/html)
2022-02-09 22:05 PST, Fujii Hironori 		no flags
Details
WIP patch (2.40 KB, patch)
2022-02-09 22:50 PST, Fujii Hironori 		no flags
DetailsFormatted DiffDiff
Patch (7.77 KB, patch)
2022-02-13 17:37 PST, Fujii Hironori 		no flags
DetailsFormatted DiffDiff
Patch (11.08 KB, patch)
2022-02-13 20:25 PST, Fujii Hironori 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Fujii Hironori
Comment 1 2022-02-09 17:22:50 PST
Created attachment 451471 [details] WIP patch
Fujii Hironori
Comment 2 2022-02-09 18:39:33 PST
Created attachment 451479 [details] WIP patch
Fujii Hironori
Comment 3 2022-02-09 22:05:14 PST
Created attachment 451493 [details] drop-shadow filter and opacity
Fujii Hironori
Comment 4 2022-02-09 22:50:04 PST
Created attachment 451494 [details] WIP patch
Fujii Hironori
Comment 5 2022-02-13 17:37:59 PST
Created attachment 451850 [details] Patch
Fujii Hironori
Comment 6 2022-02-13 20:25:13 PST
Created attachment 451854 [details] Patch
Don Olmstead
Comment 7 2022-02-15 13:06:10 PST
Comment on attachment 451854 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=451854&action=review r=me using OptionSet is probably more surgery. > Source/WebCore/platform/graphics/texmap/TextureMapperGL.cpp:476 > + TextureMapperShaderProgram::Options options = 0; Would we want to turn this into an OptionSet?
Fujii Hironori
Comment 8 2022-02-15 13:13:33 PST
Comment on attachment 451854 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=451854&action=review >> Source/WebCore/platform/graphics/texmap/TextureMapperGL.cpp:476 >> + TextureMapperShaderProgram::Options options = 0; > > Would we want to turn this into an OptionSet? Good idea. Will fix in a follow-up.
EWS
Comment 9 2022-02-15 15:07:15 PST
Committed r289855 (247297@main): <https://commits.webkit.org/247297@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 451854 [details].
Radar WebKit Bug Importer
Comment 10 2022-02-15 15:08:17 PST
<rdar://problem/88989683>
Note You need to log in before you can comment on or make changes to this bug.