| Summary: | [TextureMapperGL] drop-shadow filter with blur-radius doesn't work as expected if it is the last filter | ||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Fujii Hironori <Hironori.Fujii> | ||||||||||||||||
| Component: | Platform | Assignee: | Fujii Hironori <Hironori.Fujii> | ||||||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||||||
| Severity: | Normal | CC: | clord, cmarcelo, don.olmstead, ews-watchlist, kondapallykalyan, luiz, magomez, ujwal.koneru, webkit-bug-importer | ||||||||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||||||||
| Version: | WebKit Nightly Build | ||||||||||||||||||
| Hardware: | Unspecified | ||||||||||||||||||
| OS: | Unspecified | ||||||||||||||||||
| Attachments: |
|
||||||||||||||||||
Created attachment 451471 [details]
WIP patch
Created attachment 451479 [details]
WIP patch
Created attachment 451493 [details]
drop-shadow filter and opacity
Created attachment 451494 [details]
WIP patch
Created attachment 451850 [details]
Patch
Created attachment 451854 [details]
Patch
Comment on attachment 451854 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=451854&action=review r=me using OptionSet is probably more surgery. > Source/WebCore/platform/graphics/texmap/TextureMapperGL.cpp:476 > + TextureMapperShaderProgram::Options options = 0; Would we want to turn this into an OptionSet? Comment on attachment 451854 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=451854&action=review >> Source/WebCore/platform/graphics/texmap/TextureMapperGL.cpp:476 >> + TextureMapperShaderProgram::Options options = 0; > > Would we want to turn this into an OptionSet? Good idea. Will fix in a follow-up. Committed r289855 (247297@main): <https://commits.webkit.org/247297@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 451854 [details]. |
Created attachment 451441 [details] test case [TextureMapperGL] drop-shadow filter with blur-radius should expand the intermediate surface to render css3/filters/effect-drop-shadow-hw.html is a test case.