|Summary:||Populate role attribute for Table cells and Table header elements|
|Product:||WebKit||Reporter:||Sankar Aditya Tanguturi <sankaraditya+bugzilla>|
|Severity:||Normal||CC:||cfleizach, jcraig, klinktech, mrowe|
|Version:||528+ (Nightly build)|
Description Sankar Aditya Tanguturi 2009-01-29 22:25:03 PST
When a webpage is loaded in WebKit and Inspect32 tool is invoked, role attribute for Table Cells and Table Header elements is not properly assigned. Role attribute for those elements should be set to CellRole (ROLE_SYSTEM_CELL) This behavior can be identified in Firefox 22.214.171.124 ~ Thanks Sankar.
Comment 1 Sankar Aditya Tanguturi 2009-01-30 00:32:44 PST
Created attachment 27175 [details] Patch to populate role attribute for td and th elements. Patch to appropriately set the role attribute for td and th elements. (This behavior is implemented to match Firefox 126.96.36.199). This patch has already been approved by Jon in bug 20013. But, that bug is closed. This specific patch uploaded in this bug contains a new test case that is added. ~ Thanks Sankar.
Comment 2 Mark Rowe (bdash) 2009-02-04 22:40:02 PST
Isn't this already handled by AccessibilityTableCell?
Comment 3 Sankar Aditya Tanguturi 2009-02-05 19:23:49 PST
From the code, it seems it is already handled. But, i have taken latest nightly build and tested my test case. Table header and Table cells returns role as grouping instead of Cell. I don't know why this behavior is seen. ~ Thanks Sankar. (In reply to comment #2) > Isn't this already handled by AccessibilityTableCell? >
Comment 4 chris fleizach 2009-02-05 23:32:38 PST
there's already an accessibility table cell class
Comment 5 Sankar Aditya Tanguturi 2009-02-05 23:34:02 PST
Yeah. I have checked that class. But, I don't know why my test case fails with webkit nightly build (without applying my patch). You can try executing test case attached in that patch. ~ Thanks. (In reply to comment #4) > there's already an accessibility table cell class >
Comment 6 chris fleizach 2009-02-05 23:40:22 PST
the test fails for two reasons i see 1) the first child of the body would be a Table element 2) that table won't appear as a table, because it looks like a "layout" table. in that there are no borders
Comment 7 Sankar Aditya Tanguturi 2009-02-06 10:18:14 PST
Ok. I will check the behavior again. But, in any case, cell elements should be focusable. (This can be observed in Firefox). I will update the patch and upload the new patch. Thanks. Sankar. (In reply to comment #6) > the test fails for two reasons i see > > 1) the first child of the body would be a Table element > 2) that table won't appear as a table, because it looks like a "layout" table. > in that there are no borders >
Comment 8 chris fleizach 2009-02-06 10:20:04 PST
as far as i know, on safari a cell element cannot have focus
Comment 9 Sankar Aditya Tanguturi 2009-02-06 16:57:20 PST
If for sure, cell element on safari cannot have focus, I will close this bug. ~ Thanks Sankar. (In reply to comment #8) > as far as i know, on safari a cell element cannot have focus >
Comment 10 Eric Seidel (no email) 2009-05-11 05:44:54 PDT
Comment on attachment 27175 [details] Patch to populate role attribute for td and th elements. One of your ChangeLogs is still missing your full name. Your "Reviewed by" line is out of the normal order that ChagneLogs seem to follow. Did you run the layout tests? The last couple patches I've landed re: AX have failed layout tests. :(
Comment 11 Eric Seidel (no email) 2009-05-19 20:34:50 PDT
Comment on attachment 27175 [details] Patch to populate role attribute for td and th elements. No answer from Sankar. Marking r- assuming that this patch will break layout tests (the last two patches I landed from Sankar did). Please fix the ChangeLog and repost with a comment ensuring that you've run the layout tests with this change.
Comment 12 James Craig 2013-09-30 11:53:07 PDT
Closing as invalid. Table cells should not be focusable by default. If he needs a focusable grid, he can achieve with an ARIA grid and managed focus using tabindex.