Bug 236342

Summary: Apply default sandbox to webpushd on Mac
Product: WebKit Reporter: Ben Nham <nham>
Component: New BugsAssignee: Ben Nham <nham>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, annulen, ews-watchlist, gyuyoung.kim, nham, pvollan, ryuan.choi, sergio, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch for landing none

Description Ben Nham 2022-02-08 16:48:08 PST 
Apply default sandbox to webpushd on Mac
Comment 1 Ben Nham 2022-02-08 16:56:52 PST 
Created attachment 451326 [details]
Patch
Comment 2 Ben Nham 2022-02-08 17:19:35 PST 
Created attachment 451328 [details]
Patch
Comment 3 Radar WebKit Bug Importer 2022-02-08 20:29:26 PST 
<rdar://problem/88668389>
Comment 4 Per Arne Vollan 2022-02-10 09:41:32 PST 
Comment on attachment 451328 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=451328&action=review

R=me.

> Source/WebKit/webpushd/WebPushDaemonMain.mm:95
> +        applySandbox();

It might be good to apply the sandbox first thing in WebPushDaemonMain to avoid establishing connections to services which are blocked by the sandbox.
Comment 5 Ben Nham 2022-02-10 10:10:23 PST 
Created attachment 451562 [details]
Patch for landing
Comment 6 EWS 2022-02-10 12:14:37 PST 
Committed r289566 (247086@main): <https://commits.webkit.org/247086@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 451562 [details].