Bug 236342

Summary: Apply default sandbox to webpushd on Mac
Product: WebKit Reporter: Ben Nham <nham>
Component: New BugsAssignee: Ben Nham <nham>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, annulen, ews-watchlist, gyuyoung.kim, nham, pvollan, ryuan.choi, sergio, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch for landing none

Ben Nham
Reported 2022-02-08 16:48:08 PST
Apply default sandbox to webpushd on Mac
Attachments
Patch (21.25 KB, patch)
2022-02-08 16:56 PST, Ben Nham 		no flags
DetailsFormatted DiffDiff
Patch (20.72 KB, patch)
2022-02-08 17:19 PST, Ben Nham 		no flags
DetailsFormatted DiffDiff
Patch for landing (20.54 KB, patch)
2022-02-10 10:10 PST, Ben Nham 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Ben Nham
Comment 1 2022-02-08 16:56:52 PST
Created attachment 451326 [details] Patch
Ben Nham
Comment 2 2022-02-08 17:19:35 PST
Created attachment 451328 [details] Patch
Radar WebKit Bug Importer
Comment 3 2022-02-08 20:29:26 PST
<rdar://problem/88668389>
Per Arne Vollan
Comment 4 2022-02-10 09:41:32 PST
Comment on attachment 451328 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=451328&action=review R=me. > Source/WebKit/webpushd/WebPushDaemonMain.mm:95 > + applySandbox(); It might be good to apply the sandbox first thing in WebPushDaemonMain to avoid establishing connections to services which are blocked by the sandbox.
Ben Nham
Comment 5 2022-02-10 10:10:23 PST
Created attachment 451562 [details] Patch for landing
EWS
Comment 6 2022-02-10 12:14:37 PST
Committed r289566 (247086@main): <https://commits.webkit.org/247086@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 451562 [details].
Note You need to log in before you can comment on or make changes to this bug.