Bug 236332

Summary: [JSC] YarrJIT inlining should be disabled when we have DotStarEnclosure
Product: WebKit Reporter: Yusuke Suzuki <ysuzuki>
Component: New BugsAssignee: Yusuke Suzuki <ysuzuki>
Status: RESOLVED FIXED    
Severity: Normal CC: ews-watchlist, keith_miller, mark.lam, msaboff, saam, tzagallo, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
msaboff: review+
Patch none

Description Yusuke Suzuki 2022-02-08 14:51:12 PST 
[JSC] YarrJIT inlining should be disabled when we have DotStarEnclosure
Comment 1 Yusuke Suzuki 2022-02-08 14:52:49 PST 
Created attachment 451308 [details]
Patch
Comment 2 Yusuke Suzuki 2022-02-08 14:54:04 PST 
rdar://88483574
Comment 3 Yusuke Suzuki 2022-02-08 14:55:08 PST 
Created attachment 451309 [details]
Patch
Comment 4 Michael Saboff 2022-02-08 15:01:47 PST 
Comment on attachment 451309 [details]
Patch

r=me
Comment 5 Yusuke Suzuki 2022-02-08 15:29:59 PST 
Created attachment 451314 [details]
Patch
Comment 6 Saam Barati 2022-02-08 15:42:36 PST 
Comment on attachment 451314 [details]
Patch

Can we make the compile assertion you were hitting a RELEASE_ASSERT?
Comment 7 Yusuke Suzuki 2022-02-08 17:01:46 PST 
(In reply to Saam Barati from comment #6)
> Comment on attachment 451314 [details]
> Patch
> 
> Can we make the compile assertion you were hitting a RELEASE_ASSERT?

Discussed with Saam. We should reorganize YarrJITRegisters to avoid this issue.
Comment 8 Yusuke Suzuki 2022-02-08 17:54:36 PST 
Committed r289450 (246994@trunk): <https://commits.webkit.org/246994@trunk>