Bug 23631
| Summary: | WebKit needs a script to maintain proper SVN properties | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Eric Seidel (no email) <eric> |
| Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED LATER | ||
| Severity: | Normal | CC: | ahmad.saleem792, ap, bfulgham, darin, dbates, dglazkov, fishd, mrowe, pam, rniwa |
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | Mac | ||
| OS: | OS X 10.5 | ||
Eric Seidel (no email)
WebKit needs a script to maintain proper SVN properties
A script that would make sure that all of our .cpp and .h files have eol-style:LF on them (so they work with non-unix svn's) and to make sure that all .png files have the right mime type, etc.
Should be simple to write. Could be run easily by someone any time they experience build problems on a windows-svn checkout or similar.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Pam Greene (IRC:pamg)
Would it be too heavyweight to put a check into prepare-ChangeLog (I think that's where I'm thinking of), alongside the checks for tabs and tests and so on?
Eric Seidel (no email)
Well the tab and nobody checks are pre-commit hooks. But that's possible. It would just be one big hack to get around the fact that SVN doesn't support controlling this sort of thing server-side. :)
Ahmad Saleem
Since now Webkit moved to Github, do we need this script to make some changes in codebase or Github can handle these server-side? Thanks!
Darin Adler
I think there may still be something to do here analogous for GitHub, and it’s the kind of thing I love to do, but I don’t think it’s valuable to keep this bug open. This isn’t such a high priority that we need to use the bug database to track the idea.