| Summary: | Register strings in CSSTokenizer created from preprocessing | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Gabriel Nava Marino <gnavamarino> | ||||
| Component: | WebKit Misc. | Assignee: | Gabriel Nava Marino <gnavamarino> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, macpherson, menard, msaboff, sam, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Gabriel Nava Marino
2022-02-08 09:43:00 PST
Created attachment 451262 [details]
Patch
Comment on attachment 451262 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=451262&action=review > Source/WebCore/ChangeLog:9 > + Register strings in CSSTokenizer created from preprocessing. This will align with > + what is currently done for strings with escapes in CSSTokenizer::consumeName(). What is the benefit of this change? (In reply to Sam Weinig from comment #3) > Comment on attachment 451262 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=451262&action=review > > > Source/WebCore/ChangeLog:9 > > + Register strings in CSSTokenizer created from preprocessing. This will align with > > + what is currently done for strings with escapes in CSSTokenizer::consumeName(). > > What is the benefit of this change? Otherwise the string can go out of scope. Committed r289493 (247031@main): <https://commits.webkit.org/247031@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 451262 [details]. |