Bug 236308

Summary: [LFC][Integration] LineIteratorModernPath::baselineType should consult Display::Line
Product: WebKit Reporter: alan <zalan>
Component: Layout and RenderingAssignee: alan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, koivisto, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

alan
Reported 2022-02-08 09:28:17 PST
ssia
Attachments
Patch (10.90 KB, patch)
2022-02-08 09:44 PST, alan 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
alan
Comment 1 2022-02-08 09:44:18 PST
Created attachment 451261 [details] Patch
Antti Koivisto
Comment 2 2022-02-08 09:55:48 PST
Comment on attachment 451261 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=451261&action=review > Source/WebCore/layout/integration/LayoutIntegrationLine.h:39 > + Line(size_t firstBoxIndex, size_t boxCount, const FloatRect& lineBoxRect, float enclosingContentTop, float enclosingContentBottom, const FloatRect& scrollableOverflow, const FloatRect& inkOverflow, float baseline, FontBaseline baselineType, float contentLeft, float contentLogicalWidth) OMG we still have this
alan
Comment 3 2022-02-08 09:59:08 PST
yeah we do :(
EWS
Comment 4 2022-02-08 13:47:12 PST
Committed r289425 (246985@main): <https://commits.webkit.org/246985@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 451261 [details].
Radar WebKit Bug Importer
Comment 5 2022-02-08 13:48:17 PST
<rdar://problem/88650129>
Note You need to log in before you can comment on or make changes to this bug.