Bug 236308

Summary: [LFC][Integration] LineIteratorModernPath::baselineType should consult Display::Line
Product: WebKit Reporter: zalan <zalan>
Component: Layout and RenderingAssignee: zalan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, koivisto, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description zalan 2022-02-08 09:28:17 PST
ssia
Comment 1 zalan 2022-02-08 09:44:18 PST
Created attachment 451261 [details]
Patch
Comment 2 Antti Koivisto 2022-02-08 09:55:48 PST
Comment on attachment 451261 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=451261&action=review

> Source/WebCore/layout/integration/LayoutIntegrationLine.h:39
> +    Line(size_t firstBoxIndex, size_t boxCount, const FloatRect& lineBoxRect, float enclosingContentTop, float enclosingContentBottom, const FloatRect& scrollableOverflow, const FloatRect& inkOverflow, float baseline, FontBaseline baselineType, float contentLeft, float contentLogicalWidth)

OMG we still have this
Comment 3 zalan 2022-02-08 09:59:08 PST
yeah we do :(
Comment 4 EWS 2022-02-08 13:47:12 PST
Committed r289425 (246985@main): <https://commits.webkit.org/246985@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 451261 [details].
Comment 5 Radar WebKit Bug Importer 2022-02-08 13:48:17 PST
<rdar://problem/88650129>