| Summary: | [WPE] Developer extras are always enabled by default | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Adrian Perez <aperez> | ||||
| Component: | WPE WebKit | Assignee: | Adrian Perez <aperez> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | alex, bugs-noreply, cgarcia, zdobersek | ||||
| Priority: | P2 | ||||||
| Version: | WebKit Local Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
Created attachment 451229 [details]
Patch
Committed r289366 (246954@main): <https://commits.webkit.org/246954@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 451229 [details]. |
Currently in WPEView.cpp there is a call to enable the option unconditionally, around line 64: if (preferences) { preferences->setAcceleratedCompositingEnabled(true); preferences->setForceCompositingMode(true); preferences->setThreadedScrollingEnabled(true); preferences->setWebGLEnabled(true); preferences->setDeveloperExtrasEnabled(true); } This should be disabled by default, and when needed users would opt-in with webkit_settings_set_enable_developer_extras(settings, TRUE) via the public API.