Bug 236295

Summary: [WPE] Developer extras are always enabled by default
Product: WebKit Reporter: Adrian Perez <aperez>
Component: WPE WebKitAssignee: Adrian Perez <aperez>
Status: RESOLVED FIXED    
Severity: Normal CC: alex, bugs-noreply, cgarcia, zdobersek
Priority: P2    
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Adrian Perez
Reported 2022-02-08 02:49:45 PST
Currently in WPEView.cpp there is a call to enable the option unconditionally, around line 64: if (preferences) { preferences->setAcceleratedCompositingEnabled(true); preferences->setForceCompositingMode(true); preferences->setThreadedScrollingEnabled(true); preferences->setWebGLEnabled(true); preferences->setDeveloperExtrasEnabled(true); } This should be disabled by default, and when needed users would opt-in with webkit_settings_set_enable_developer_extras(settings, TRUE) via the public API.
Attachments
Patch (1.34 KB, patch)
2022-02-08 03:00 PST, Adrian Perez 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Adrian Perez
Comment 1 2022-02-08 03:00:10 PST
Created attachment 451229 [details] Patch
EWS
Comment 2 2022-02-08 04:33:24 PST
Committed r289366 (246954@main): <https://commits.webkit.org/246954@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 451229 [details].
Note You need to log in before you can comment on or make changes to this bug.