Bug 23628

Summary:

Fix selection painting to do container-relative repaints

Product:

WebKit

Reporter:

Simon Fraser (smfr) <simon.fraser>

Component:

Layout and Rendering

Assignee:

Simon Fraser (smfr) <simon.fraser>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

hyatt, mitz, webkit.review.bot

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

Mac

OS:

OS X 10.5

Bug Depends on:

Bug Blocks:

23359

Attachments:

Description	Flags
Patch, changelog.	none
Patch	none

Simon Fraser (smfr)

Reported 2009-01-29 15:36:00 PST

Selection currently repaints via the view. This needs to be fixed to make repaints container-relative.

Attachments
Patch, changelog. (35.95 KB, patch) 2009-02-03 17:48 PST, Simon Fraser (smfr)	no flags	Details Formatted Diff Diff
Patch (25.16 KB, patch) 2009-12-03 15:34 PST, mitz	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Simon Fraser (smfr)

Comment 1 2009-02-03 17:48:58 PST

Created attachment 27305 [details] Patch, changelog.

Dave Hyatt

Comment 2 2009-02-03 18:12:42 PST

Comment on attachment 27305 [details] Patch, changelog. r=me Run pixel tests before landing this, since that's the only way to see some of this in action.

Simon Fraser (smfr)

Comment 3 2009-02-03 18:42:00 PST

Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog M WebCore/GNUmakefile.am M WebCore/WebCore.vcproj/WebCore.vcproj M WebCore/WebCore.xcodeproj/project.pbxproj M WebCore/rendering/RenderBR.h M WebCore/rendering/RenderBlock.cpp M WebCore/rendering/RenderBlock.h M WebCore/rendering/RenderListMarker.cpp M WebCore/rendering/RenderListMarker.h M WebCore/rendering/RenderObject.h M WebCore/rendering/RenderReplaced.cpp M WebCore/rendering/RenderReplaced.h M WebCore/rendering/RenderSVGInlineText.cpp M WebCore/rendering/RenderSVGInlineText.h A WebCore/rendering/RenderSelectionInfo.h M WebCore/rendering/RenderText.cpp M WebCore/rendering/RenderText.h M WebCore/rendering/RenderView.cpp M WebCore/rendering/RenderView.h M WebCore/rendering/RenderWidget.cpp Committed r40564

Simon Fraser (smfr)

Comment 4 2009-02-03 18:42:34 PST

Comment on attachment 27305 [details] Patch, changelog. Landed in r40564. Keeping open to fix RenderBlock::selectionGapRectsForRepaint()

Simon Fraser (smfr)

Comment 5 2009-02-06 20:10:07 PST

Comment on attachment 27305 [details] Patch, changelog. Getting out of the 'patches to land' queue.

Simon Fraser (smfr)

Comment 6 2009-11-20 13:54:28 PST

<rdar://problem/7401617>

mitz

Comment 7 2009-12-03 15:34:13 PST

Created attachment 44272 [details] Patch